code review feedback

68383cd

Select commit

Loading

Failed to load commit list.

Uh oh!

There was an error while loading. Please reload this page.

DCO

Cluster (vttablet_prscomplex) on: pull_request 1

Run endtoend tests on Cluster (vttablet_prscomplex)

Query Serving (Schema) Next Release - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Query Serving (Schema) Next Release

Backups - Manual - Next Release - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Backups - Manual - Next Release

Cluster (vreplication_vtctldclient_movetables_tz) on: pull_request 1

Run endtoend tests on Cluster (vreplication_vtctldclient_movetables_tz)

Cluster (12) on: pull_request 1

Run endtoend tests on Cluster (12)

Cluster (vtbackup) on: pull_request 1

Run endtoend tests on Cluster (vtbackup)

Cluster (vtgate_foreignkey_stress) on: pull_request 1

Run endtoend tests on Cluster (vtgate_foreignkey_stress)

Backups - E2E - Next Release - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Backups - E2E - Next Release

Cluster (vtgate_concurrentdml) on: pull_request 1

Run endtoend tests on Cluster (vtgate_concurrentdml)

Cluster (vreplication_basic) on: pull_request 1

Run endtoend tests on Cluster (vreplication_basic)

Cluster (vreplication_migrate) on: pull_request 1

Run endtoend tests on Cluster (vreplication_migrate)

Cluster (tabletmanager_tablegc) on: pull_request 1

Run endtoend tests on Cluster (tabletmanager_tablegc)

Cluster (onlineddl_vrepl_stress_suite) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite)

Unit Test (mysql80) on: pull_request 1

Unit Test (mysql80)

Query Serving (Queries - 2) - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Query Serving (Queries - 2)

Unit Test (mysql57) on: pull_request 1

Unit Test (mysql57)

Cluster (vtctlbackup_sharded_clustertest_heavy) on: pull_request 1

Run endtoend tests on Cluster (vtctlbackup_sharded_clustertest_heavy)

Cluster (vreplication_copy_parallel) on: pull_request 1

Run endtoend tests on Cluster (vreplication_copy_parallel)

Cluster (vreplication_foreign_key_stress) on: pull_request 1

Run endtoend tests on Cluster (vreplication_foreign_key_stress)

Query Serving (Schema) - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Query Serving (Schema)

Cluster (tabletmanager_throttler_topo) on: pull_request 1

Run endtoend tests on Cluster (tabletmanager_throttler_topo)

Cluster (vtgate_general_heavy) on: pull_request 1

Run endtoend tests on Cluster (vtgate_general_heavy)

Cluster (15) on: pull_request 1

Run endtoend tests on Cluster (15)

Cluster (vreplication_across_db_versions) on: pull_request 1

Run endtoend tests on Cluster (vreplication_across_db_versions)

Unit Test (evalengine_mysql57) on: pull_request 1

Unit Test (evalengine_mysql57)

Cluster (onlineddl_vrepl_stress) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_vrepl_stress)

vtop_example on: pull_request

VTop Example

java_docker_test on: pull_request

Java Docker Test

Cluster (vtgate_unsharded) on: pull_request 1

Run endtoend tests on Cluster (vtgate_unsharded)

Cluster (vtgate_vschema) on: pull_request 1

Run endtoend tests on Cluster (vtgate_vschema)

Cluster (topo_connection_cache) on: pull_request 1

Run endtoend tests on Cluster (topo_connection_cache)

Cluster (onlineddl_revert) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_revert)

Cluster (vreplication_partial_movetables_and_materialize) on: pull_request 3

Run endtoend tests on Cluster (vreplication_partial_movetables_and_materialize)

Cluster (backup_pitr_xtrabackup) on: pull_request 1

Run endtoend tests on Cluster (backup_pitr_xtrabackup)

Cluster (vreplication_cellalias) on: pull_request 1

Run endtoend tests on Cluster (vreplication_cellalias)

Cluster (backup_pitr_mysqlshell) on: pull_request 1

Run endtoend tests on Cluster (backup_pitr_mysqlshell)

Cluster (vtgate_schema_tracker) on: pull_request 1

Run endtoend tests on Cluster (vtgate_schema_tracker)

Query Serving (Queries - 2) Next Release - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Query Serving (Queries - 2) Next Release

Reparent New Vtctl - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Reparent New Vtctl

Query Serving (Queries) - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Query Serving (Queries)

Cluster (vtgate_godriver) on: pull_request 1

Run endtoend tests on Cluster (vtgate_godriver)

Cluster (mysql84) on: pull_request 1

Run endtoend tests on Cluster (mysql84)

Cluster (onlineddl_scheduler) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_scheduler)

Cluster (tabletmanager_consul) on: pull_request 1

Run endtoend tests on Cluster (tabletmanager_consul)

Online DDL flow - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Online DDL flow

Cluster (vtgate_topo_consul) on: pull_request 1

Run endtoend tests on Cluster (vtgate_topo_consul)

Cluster (vtgate_topo_etcd) on: pull_request 1

Run endtoend tests on Cluster (vtgate_topo_etcd)

Code Coverage on: pull_request 1

Code Coverage

Cluster (onlineddl_vrepl) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_vrepl)

Cluster (mysql_server_vault) on: pull_request 1

Run endtoend tests on Cluster (mysql_server_vault)

Cluster (vtgate_queries) on: pull_request 1

Run endtoend tests on Cluster (vtgate_queries)

Reparent Old Vtctl - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Reparent Old Vtctl

Cluster (onlineddl_vrepl_suite) on: pull_request 1

Run endtoend tests on Cluster (onlineddl_vrepl_suite)

check_make_vtadmin_web_proto on: pull_request

Check Make VTAdmin Web Proto

Cluster (21) on: pull_request 1

Run endtoend tests on Cluster (21)

Cluster (vtgate_transaction) on: pull_request 1

Run endtoend tests on Cluster (vtgate_transaction)

Unit Test (evalengine_mysql84) on: pull_request 1

Unit Test (evalengine_mysql84)

Cluster (vtgate_plantests) on: pull_request 1

Run endtoend tests on Cluster (vtgate_plantests)

Unit Test (evalengine_mysql80) on: pull_request 1

Unit Test (evalengine_mysql80)

Cluster (vtgate_vindex_heavy) on: pull_request 1

Run endtoend tests on Cluster (vtgate_vindex_heavy)

Unit Test (Evalengine_Race) on: pull_request 1

Unit Test (Evalengine_Race)

e2e_race on: pull_request

End-to-End Test (Race)

Cluster (vtgate_partial_keyspace) on: pull_request 1

Run endtoend tests on Cluster (vtgate_partial_keyspace)

Reparent Old VTTablet - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Reparent Old VTTablet

check_make_vtadmin_authz_testgen on: pull_request

Check Make vtadmin_authz_testgen

Cluster (xb_backup) on: pull_request 1

Run endtoend tests on Cluster (xb_backup)

Check Pull Request labels on: pull_request

Check Pull Request labels

Cluster (ers_prs_newfeatures_heavy) on: pull_request 1

Run endtoend tests on Cluster (ers_prs_newfeatures_heavy)

Cluster (vreplication_vdiff2) on: pull_request 1

Run endtoend tests on Cluster (vreplication_vdiff2)

Cluster (vtgate_gen4) on: pull_request 1

Run endtoend tests on Cluster (vtgate_gen4)

Reparent New VTTablet - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Reparent New VTTablet

Code Freeze on: pull_request

Code Freeze

local_example on: pull_request

Local example using etcd on Ubuntu

Local example using zk2 on Ubuntu

docker_test_cluster on: pull_request

Docker Test Cluster

Cluster (schemadiff_vrepl) on: pull_request 1

Run endtoend tests on Cluster (schemadiff_vrepl)

Cluster (backup_pitr) on: pull_request 1

Run endtoend tests on Cluster (backup_pitr)

Unit Test (Race) on: pull_request 1

Unit Test (Race)

Semi Sync Upgrade Downgrade Testing on: pull_request 1

Run Semi Sync Upgrade Downgrade Test

Cluster (xb_recovery) on: pull_request 1

Run endtoend tests on Cluster (xb_recovery)

Static Code Checks, Etc. on: pull_request

Static Code Checks Etc

Vitess Tester (vtgate) on: pull_request 1

Run endtoend tests on Vitess Tester (vtgate)

Cluster (vtgate_schema) on: pull_request 1

Run endtoend tests on Cluster (vtgate_schema)

Cluster (13) on: pull_request 1

Run endtoend tests on Cluster (13)

Cluster (vtgate_readafterwrite) on: pull_request 1

Run endtoend tests on Cluster (vtgate_readafterwrite)

region_example on: pull_request

Region Sharding example using etcd on Ubuntu

Cluster (vtgate_topo) on: pull_request 1

Run endtoend tests on Cluster (vtgate_topo)

Cluster (vtgate_reservedconn) on: pull_request 1

Run endtoend tests on Cluster (vtgate_reservedconn)

Unit Test (mysql84) on: pull_request 1

Unit Test (mysql84)

endtoend on: pull_request

End-to-End Test

Cluster (vstream) on: pull_request 1

Run endtoend tests on Cluster (vstream)

Cluster (vtgate_tablet_healthcheck_cache) on: pull_request 1

Run endtoend tests on Cluster (vtgate_tablet_healthcheck_cache)

Cluster (vreplication_mariadb_to_mysql) on: pull_request 1

Run endtoend tests on Cluster (vreplication_mariadb_to_mysql)

Cluster (vtorc) on: pull_request 1

Run endtoend tests on Cluster (vtorc)

Cluster (18) on: pull_request 1

Run endtoend tests on Cluster (18)

Backups - Manual - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Backups - Manual

Backups - E2E - Upgrade Downgrade Testing on: pull_request 1

Run Upgrade Downgrade Test - Backups - E2E

Query Serving (Queries) Next Release - Upgrade Downgrade Testing on: pull_request

Run Upgrade Downgrade Test - Query Serving (Queries) Next Release

Cluster (vreplication_v2) on: pull_request 1

Run endtoend tests on Cluster (vreplication_v2)

Cluster (vreplication_multi_tenant) on: pull_request 1

Run endtoend tests on Cluster (vreplication_multi_tenant)

Backport and Forwardport PRs on: pull_request_target 1

Backport/Forwardport PR

DCO / DCO succeeded Jan 7, 2026 in 0s

DCO

All commits are signed off!

View more details on DCO

Loading

code review feedback

Uh oh!

DCO

Re-running checks...