Skip to content

Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient#19085

Merged
mhamza15 merged 6 commits into
vitessio:mainfrom
mhamza15:reload-schema-req
Jan 12, 2026
Merged

Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient#19085
mhamza15 merged 6 commits into
vitessio:mainfrom
mhamza15:reload-schema-req

remove fix and properly reset state between tests

8e237fb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2026 in 0s

69.89% (+0.01%) compared to ffa1e9b

View this Pull Request on Codecov

69.89% (+0.01%) compared to ffa1e9b

Details

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (ffa1e9b) to head (8e237fb).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/grpctmclient/client.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19085      +/-   ##
==========================================
+ Coverage   69.88%   69.89%   +0.01%     
==========================================
  Files        1612     1613       +1     
  Lines      215822   216023     +201     
==========================================
+ Hits       150828   150996     +168     
- Misses      64994    65027      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.