Skip to content

[release-23.0] VDiff: Handle the case where a workflow's table has been dropped on the source (#18985)#18989

Merged
mattlord merged 2 commits intorelease-23.0from
backport-18985-to-release-23.0
Dec 5, 2025
Merged

[release-23.0] VDiff: Handle the case where a workflow's table has been dropped on the source (#18985)#18989
mattlord merged 2 commits intorelease-23.0from
backport-18985-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 4, 2025

Description

This is a backport of #18985

…he source (#18985)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 4, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v23.0.1 milestone Dec 4, 2025
@promptless
Copy link
Contributor

promptless bot commented Dec 4, 2025

📝 Documentation updates detected!

New suggestion: Add changelog entry for VDiff bug fix #18989

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the backport-18985-to-release-23.0 branch from 4ee461d to cf3f338 Compare December 5, 2025 00:20
@mattlord mattlord merged commit a06904e into release-23.0 Dec 5, 2025
100 of 102 checks passed
@mattlord mattlord deleted the backport-18985-to-release-23.0 branch December 5, 2025 01:00
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…en dropped on the source (vitessio#18985) (vitessio#18989)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…en dropped on the source (vitessio#18985) (vitessio#18989)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…en dropped on the source (vitessio#18985) (vitessio#18989)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…en dropped on the source (vitessio#18985) (vitessio#18989)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant