Skip to content

[release-23.0] Drop dependency on npm, bump version of glob. (#18931)#18958

Merged
arthurschreiber merged 1 commit intorelease-23.0from
backport-18931-to-release-23.0
Nov 28, 2025
Merged

[release-23.0] Drop dependency on npm, bump version of glob. (#18931)#18958
arthurschreiber merged 1 commit intorelease-23.0from
backport-18931-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Nov 28, 2025

Description

This is a backport of #18931

@vitess-bot
Drop dependency on npm, bump version of glob. (#18931)
6c0b88f 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot vitess-bot bot requested a review from beingnoble03 as a code owner November 28, 2025 16:59
@vitess-bot vitess-bot bot added the Component: VTAdmin VTadmin interface label Nov 28, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Nov 28, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Security Backport This is a backport labels Nov 28, 2025
@vitess-bot vitess-bot bot requested a review from arthurschreiber November 28, 2025 16:59
@github-actions github-actions bot added this to the v23.0.1 milestone Nov 28, 2025
@arthurschreiber arthurschreiber removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 28, 2025
@arthurschreiber arthurschreiber merged commit 89c6a8f into release-23.0 Nov 28, 2025
109 of 117 checks passed
@arthurschreiber arthurschreiber deleted the backport-18931-to-release-23.0 branch November 28, 2025 17:06
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot
[release-23.0] Drop dependency on npm, bump version of glob. (vit…
41620d7 
…essio#18931) (vitessio#18958)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot
[release-23.0] Drop dependency on npm, bump version of glob. (vit…
410ffbe 
…essio#18931) (vitessio#18958)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot
[release-23.0] Drop dependency on npm, bump version of glob. (vit…
289149e 
…essio#18931) (vitessio#18958)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot
[release-23.0] Drop dependency on npm, bump version of glob. (vit…
df2569f 
…essio#18931) (vitessio#18958)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: VTAdmin VTadmin interface Type: Security

Projects

None yet

Milestone

v23.0.1

Development

Successfully merging this pull request may close these issues.

1 participant

@arthurschreiber