Skip to content

[release-23.0] Don't hardcode the go version to use for upgrade/downgrade tests. (#18920)#18956

Merged
timvaillancourt merged 1 commit intorelease-23.0from
backport-18920-to-release-23.0
Nov 30, 2025
Merged

[release-23.0] Don't hardcode the go version to use for upgrade/downgrade tests. (#18920)#18956
timvaillancourt merged 1 commit intorelease-23.0from
backport-18920-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot commented Nov 27, 2025

Description

This is a backport of #18920

@vitess-bot
Don't hardcode the go version to use for upgrade/downgrade tests. (#1…
586ea01 
…8920)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 27, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 27, 2025
@github-actions github-actions bot added this to the v23.0.1 milestone Nov 27, 2025
@arthurschreiber arthurschreiber added the Backport This is a backport label Nov 27, 2025
@vitess-bot vitess-bot added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 27, 2025
@timvaillancourt timvaillancourt self-requested a review November 30, 2025 13:23
@timvaillancourt timvaillancourt merged commit 461c569 into release-23.0 Nov 30, 2025
106 of 114 checks passed
@timvaillancourt timvaillancourt deleted the backport-18920-to-release-23.0 branch November 30, 2025 13:23
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot @vitess-bot
[release-23.0] Don't hardcode the go version to use for upgrade/downg…
bc4616c 
…rade tests. (vitessio#18920) (vitessio#18956)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot @vitess-bot
[release-23.0] Don't hardcode the go version to use for upgrade/downg…
26c9f62 
…rade tests. (vitessio#18920) (vitessio#18956)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot @vitess-bot
[release-23.0] Don't hardcode the go version to use for upgrade/downg…
f275209 
…rade tests. (vitessio#18920) (vitessio#18956)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@vitess-bot @vitess-bot
[release-23.0] Don't hardcode the go version to use for upgrade/downg…
254bdb4 
…rade tests. (vitessio#18920) (vitessio#18956)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

v23.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@vitess-bot @arthurschreiber @timvaillancourt