Run VStream copy only when VGTID requires it, use TablesToCopy in those cases

[twthorn]

Description

We are running vstream copy whenever this TablesToCopy flag is set. It should only be used if the VGTID would trigger the copy. Otherwise, there is a race condition (clients must unset their VStream config in time to avoid repeated copies). By only running copies when the VGTID requires it, we avoid repeated copies after the operation is complete (and will ignore this flag)

Note

This is a small logic bug in #18184 . That work should result in modifying the table plan built when we specify tables to copy, but it should not cause any new/additional copy phases (than before that PR). Since that was added in v23, we should backport this fix to v23.

Related Issue(s)

• Fixes: Bug Report: TablesToCopy flag always triggers copies even with existing GTID #18937

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

AI Disclosure

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.78%. Comparing base (e1df3d1) to head (471f694).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18938      +/-   ##
==========================================
+ Coverage   69.77%   69.78%   +0.01%     
==========================================
  Files        1608     1608              
  Lines      214842   214865      +23     
==========================================
+ Hits       149899   149945      +46     
+ Misses      64943    64920      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mattlord]

Thanks, @twthorn ! ❤️

[beingnoble03]

LGTM! Thanks for fixing this!