Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check_make_vtadmin_web_proto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# node-version should match package.json
node-version: '22.13.1'
node-version: '25.2.1'

- name: Install npm dependencies
if: steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static_checks_etc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# make proto requires newer node than the pre-installed one
node-version: '22.13.1'
node-version: '25.2.1'

- name: check_make_proto
if: steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- uses: actions/setup-node@v4
with:
# node-version should match package.json
node-version: '22.13.1'
node-version: '25.2.1'

- name: Install dependencies
run: cd ./web/vtadmin && npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- uses: actions/setup-node@v4
with:
# node-version should match package.json
node-version: '22.13.1'
node-version: '25.2.1'

- name: Install dependencies
run: cd ./web/vtadmin && npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- uses: actions/setup-node@v4
with:
# node-version should match package.json
node-version: '22.13.1'
node-version: '25.2.1'

- name: Install dependencies
run: cd ./web/vtadmin && npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/vtop_example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
if: steps.changes.outputs.end_to_end == 'true'
run: |
# Install everything we need, and configure
sudo apt-get install -y make
sudo apt-get install -y libatomic1 make
go mod download

# needed for vtctldclient
Expand All @@ -83,4 +83,4 @@ jobs:
timeout-minutes: 60
run: |
source build.env
go run test.go -docker=false -skip-build -print-log -follow -retry=1 -timeout=60m vtop_example
go run test.go -docker=false -skip-build -print-log -follow -retry=1 -timeout=60m vtop_example
9 changes: 9 additions & 0 deletions changelog/24.0/24.0.0/summary.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,20 @@
### Table of Contents

- **[Minor Changes](#minor-changes)**
- **[VTAdmin](#minor.change-vtadmin)**
- [Updated to node v25.2.1](#vtadmin-updated-node)
- **[VTGate](#minor-changes-vtgate)**
- [New default for `--legacy-replication-lag-algorithm` flag](#vtgate-new-default-legacy-replication-lag-algorithm)

## <a id="minor-changes"/>Minor Changes</a>

### <a id="minor-changes-vtadmin"/>VTAdmin</a>

#### <a id="vtadmin-updated-node"/>Updated to node v25.2.1</a>

Building `vtadmin-web` now requires node >= v25.2.1 (LTS). Breaking changes from v22 to v25 can be found at https://nodejs.org/en/blog/release/v25.2.1 -- with no known issues that apply to VTAdmin.
Full details on the node v25.2.1 release can be found at https://nodejs.org/en/blog/release/v25.2.1.

### <a id="minor-changes-vtgate"/>VTGate</a>

#### <a id="vtgate-new-default-legacy-replication-lag-algorithm"/>New default for `--legacy-replication-lag-algorithm` flag</a>
Expand Down
2 changes: 1 addition & 1 deletion docker/binaries/vtadmin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ARG DEBIAN_VER=bookworm-slim

FROM vitess/lite:${VT_BASE_VER} AS lite

FROM node:22-${DEBIAN_VER} as node
FROM node:25-${DEBIAN_VER} as node

# Prepare directory structure.
RUN mkdir -p /vt/web
Expand Down
2 changes: 1 addition & 1 deletion tools/check_make_vtadmin_web_proto.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ if [[ "$diff" != "" ]]; then
exit 1
fi

echo "VTAdmin Web Protos are up to date"
echo "VTAdmin Web Protos are up to date"
4 changes: 2 additions & 2 deletions web/vtadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Prerequisites

- [node](https://nodejs.org) >= 22.13.1 LTS
- npm >= 10.9.2 (comes with node)
- [node](https://nodejs.org) >= 25.2.1 LTS
- npm >= 11.6.0 (comes with node)

## Available scripts

Expand Down
2 changes: 1 addition & 1 deletion web/vtadmin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if [[ -z ${NVM_DIR} ]]; then
fi

if [[ -z ${NODE_VERSION} ]]; then
export NODE_VERSION="22.13.1"
export NODE_VERSION="25.2.1"
fi

output "\nInstalling nvm...\n"
Expand Down
Loading
Loading