Skip to content

Don't hardcode the go version to use for upgrade/downgrade tests. #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurschreiber merged 5 commits into from
Nov 27, 2025
Merged

Don't hardcode the go version to use for upgrade/downgrade tests. #18920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9eb44e
Don't hardcode the go version to use for upgrade/downgrade tests.
arthurschreiber Nov 20, 2025
4af86f4
Update more workflows.
arthurschreiber Nov 20, 2025
04b9acb
Update all upgrade/downgrade workflows.
arthurschreiber Nov 20, 2025
507575d
Fix a typo.
arthurschreiber Nov 20, 2025
7e4197a
Skip installing the `go-junit-report` when it's not being used.
arthurschreiber Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions .github/workflows/upgrade_downgrade_test_backups_e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,14 @@ jobs:
- 'bootstrap.sh'
- '.github/workflows/upgrade_downgrade_test_backups_e2e.yml'

- name: Set up Go
- name: Tune the OS
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version: 1.24.7
Copy link
Member Author

@arthurschreiber arthurschreiber Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we missed upgrading this value when v23 was released. Changing this to not hardcode this value will ensure we won't miss updating this value in the future.

uses: ./.github/actions/tune-os

- name: Set up python
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1

- name: Tune the OS
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/tune-os

- name: Setup MySQL
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/setup-mysql
Expand All @@ -93,11 +87,6 @@ jobs:

sudo service etcd stop

go mod download

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD
Comment on lines -96 to -99
Copy link
Member Author

@arthurschreiber arthurschreiber Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade/downgrade tests don't use go-junit-report, so there's no need to install it here.


wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
Expand All @@ -113,6 +102,13 @@ jobs:
ref: ${{ steps.output-previous-release-ref.outputs.previous_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

Comment on lines +105 to +111
Copy link
Member Author

@arthurschreiber arthurschreiber Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pulls the required go version from the go.mod file.

- name: Get dependencies for the last release
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -135,6 +131,13 @@ jobs:
with:
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for this commit
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
29 changes: 16 additions & 13 deletions .github/workflows/upgrade_downgrade_test_backups_e2e_next_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,14 @@ jobs:
- 'bootstrap.sh'
- '.github/workflows/upgrade_downgrade_test_backups_e2e_next_release.yml'

- name: Set up Go
- name: Tune the OS
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
uses: ./.github/actions/tune-os

- name: Set up python
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1

- name: Tune the OS
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/tune-os

- name: Setup MySQL
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/setup-mysql
Expand All @@ -95,11 +89,6 @@ jobs:

sudo service etcd stop

go mod download

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
Expand All @@ -115,6 +104,13 @@ jobs:
ref: ${{ steps.output-next-release-ref.outputs.next_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for the next release
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -137,6 +133,13 @@ jobs:
with:
persist-credentials: 'false'

- name: Set up Go
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for this commit
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
43 changes: 25 additions & 18 deletions .github/workflows/upgrade_downgrade_test_backups_manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ jobs:
fetch-depth: 0
persist-credentials: 'false'

- name: Set output with latest release branch
id: output-previous-release-ref
run: |
previous_release_ref=$(./tools/get_previous_release.sh ${{github.base_ref}} ${{github.ref}})
echo $previous_release_ref
echo "previous_release_ref=${previous_release_ref}" >> $GITHUB_OUTPUT

- name: Check for changes in relevant files
uses: dorny/paths-filter@ebc4d7e9ebcb0b1eb21480bb8f43113e996ac77a # v3.0.1
id: changes
Expand All @@ -66,20 +59,23 @@ jobs:
- '.github/workflows/upgrade_downgrade_test_backups_manual.yml'
- 'examples/**'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version: 1.24.7

- name: Set up python
- name: Set output with latest release branch
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
id: output-previous-release-ref
run: |
previous_release_ref=$(./tools/get_previous_release.sh ${{github.base_ref}} ${{github.ref}})
echo $previous_release_ref
echo "previous_release_ref=${previous_release_ref}" >> $GITHUB_OUTPUT

- name: Tune the OS
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/tune-os

- name: Set up python
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1

- name: Setup MySQL
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/setup-mysql
Expand All @@ -97,9 +93,6 @@ jobs:

sudo service etcd stop

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
Expand All @@ -115,6 +108,13 @@ jobs:
ref: ${{ steps.output-previous-release-ref.outputs.previous_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for the last release
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -137,6 +137,13 @@ jobs:
with:
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for this commit
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down Expand Up @@ -278,7 +285,7 @@ jobs:
echo "select count(sku) from corder;" | mysql 2>&1| grep 6

- name: Stop the Vitess cluster
if: always() && steps.changes.outputs.end_to_end == 'true'
if: steps.changes.outputs.end_to_end == 'true' && !cancelled()
run: |
source build.env ; cd examples/local
./401_teardown.sh || true
44 changes: 25 additions & 19 deletions .github/workflows/upgrade_downgrade_test_backups_manual_next_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ jobs:
fetch-depth: 0
persist-credentials: 'false'

- name: Set output with latest release branch
id: output-next-release-ref
run: |
next_release_ref=$(./tools/get_next_release.sh ${{github.base_ref}} ${{github.ref}})
echo $next_release_ref
echo "next_release_ref=${next_release_ref}" >> $GITHUB_OUTPUT

- name: Check for changes in relevant files
if: steps.output-next-release-ref.outputs.next_release_ref != ''
uses: dorny/paths-filter@ebc4d7e9ebcb0b1eb21480bb8f43113e996ac77a # v3.0.1
Expand All @@ -67,20 +60,22 @@ jobs:
- '.github/workflows/upgrade_downgrade_test_backups_manual_next_release.yml'
- 'examples/**'

- name: Set up Go
- name: Set output with latest release branch
id: output-next-release-ref
if: steps.changes.outputs.end_to_end == 'true'
run: |
next_release_ref=$(./tools/get_next_release.sh ${{github.base_ref}} ${{github.ref}})
echo $next_release_ref
echo "next_release_ref=${next_release_ref}" >> $GITHUB_OUTPUT

- name: Tune the OS
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
uses: ./.github/actions/tune-os

- name: Set up python
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1

- name: Tune the OS
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/tune-os

- name: Setup MySQL
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/setup-mysql
Expand All @@ -98,9 +93,6 @@ jobs:

sudo service etcd stop

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
Expand All @@ -116,6 +108,13 @@ jobs:
ref: ${{ steps.output-next-release-ref.outputs.next_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for the next release
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -138,6 +137,13 @@ jobs:
with:
persist-credentials: 'false'

- name: Set up Go
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for this commit
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down Expand Up @@ -279,7 +285,7 @@ jobs:
echo "select count(sku) from corder;" | mysql 2>&1| grep 6

- name: Stop the Vitess cluster
if: always() && steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true'
if: steps.output-next-release-ref.outputs.next_release_ref != '' && steps.changes.outputs.end_to_end == 'true' && !cancelled()
run: |
source build.env ; cd examples/local
./401_teardown.sh || true
36 changes: 25 additions & 11 deletions .github/workflows/upgrade_downgrade_test_onlineddl_flow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,33 +60,29 @@ jobs:
- '.github/workflows/upgrade_downgrade_test_onlineddl_flow.yml'

- name: Set output with latest release branch
if: steps.changes.outputs.end_to_end == 'true'
id: output-previous-release-ref
run: |
previous_release_ref=$(./tools/get_previous_release.sh ${{github.base_ref}} ${{github.ref}})
echo $previous_release_ref
echo "previous_release_ref=${previous_release_ref}" >> $GITHUB_OUTPUT

- name: Set output with next release branch
if: steps.changes.outputs.end_to_end == 'true'
id: output-next-release-ref
run: |
next_release_ref=$(./tools/get_next_release.sh ${{github.base_ref}} ${{github.ref}})
echo $next_release_ref
echo "next_release_ref=${next_release_ref}" >> $GITHUB_OUTPUT

- name: Set up Go
- name: Tune the OS
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version: 1.24.7
uses: ./.github/actions/tune-os

- name: Set up python
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1

- name: Tune the OS
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/tune-os

- name: Setup MySQL
if: steps.changes.outputs.end_to_end == 'true'
uses: ./.github/actions/setup-mysql
Expand All @@ -104,9 +100,6 @@ jobs:

sudo service etcd stop

# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

# Checkout to the last release of Vitess
- name: Check out last version's code (${{ steps.output-previous-release-ref.outputs.previous_release_ref }})
if: steps.changes.outputs.end_to_end == 'true'
Expand All @@ -115,6 +108,13 @@ jobs:
ref: ${{ steps.output-previous-release-ref.outputs.previous_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for the last release
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -139,6 +139,13 @@ jobs:
ref: ${{ steps.output-next-release-ref.outputs.next_release_ref }}
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for the next release
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand All @@ -162,6 +169,13 @@ jobs:
with:
persist-credentials: 'false'

- name: Set up Go
if: steps.changes.outputs.end_to_end == 'true'
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
with:
go-version-file: go.mod
cache: false

- name: Get dependencies for this commit
if: steps.changes.outputs.end_to_end == 'true'
run: |
Expand Down
Loading
Loading