Skip to content

[release-23.0] BuiltinBackupEngine: Retry file close and fail backup when we cannot (#18848)#18862

Merged
mattlord merged 1 commit intorelease-23.0from
backport-18848-to-release-23.0
Nov 4, 2025
Merged

[release-23.0] BuiltinBackupEngine: Retry file close and fail backup when we cannot (#18848)#18862
mattlord merged 1 commit intorelease-23.0from
backport-18848-to-release-23.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Nov 3, 2025

Description

This is a backport of #18848

@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Nov 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from arthurschreiber November 3, 2025 23:56
@github-actions github-actions bot added this to the v23.0.0 milestone Nov 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.70%. Comparing base (58344e1) to head (e7507b1).
⚠️ Report is 15 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/vt/mysqlctl/builtinbackupengine.go 73.58% 14 Missing ⚠️
go/vt/mysqlctl/gcsbackupstorage/gcs.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.0   #18862   +/-   ##
=============================================
  Coverage         69.70%   69.70%           
=============================================
  Files              1605     1606    +1     
  Lines            214449   214514   +65     
=============================================
+ Hits             149475   149529   +54     
- Misses            64974    64985   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@systay systay mentioned this pull request Nov 4, 2025
44 tasks
@systay systay modified the milestones: v23.0.0, v23.0.1 Nov 4, 2025
@mattlord mattlord enabled auto-merge (squash) November 4, 2025 16:01
@mattlord mattlord merged commit 9fcc17e into release-23.0 Nov 4, 2025
118 of 203 checks passed
@mattlord mattlord deleted the backport-18848-to-release-23.0 branch November 4, 2025 16:23
timvaillancourt pushed a commit that referenced this pull request Nov 4, 2025
…when we cannot (#18848) (#18862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…when we cannot (vitessio#18848) (vitessio#18862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…when we cannot (vitessio#18848) (vitessio#18862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…when we cannot (vitessio#18848) (vitessio#18862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…when we cannot (vitessio#18848) (vitessio#18862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants