Skip to content

[release-23.0] copy_state: use a mediumblob instead of a smaller varbinary for lastpk (#18852)#18859

Merged
nickvanw merged 1 commit intorelease-23.0from
backport-18852-to-release-23.0
Nov 4, 2025
Merged

[release-23.0] copy_state: use a mediumblob instead of a smaller varbinary for lastpk (#18852)#18859
nickvanw merged 1 commit intorelease-23.0from
backport-18852-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Nov 3, 2025

Description

This is a backport of #18852

@vitess-bot vitess-bot bot added Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug labels Nov 3, 2025
@vitess-bot vitess-bot bot requested a review from nickvanw November 3, 2025 21:25
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Nov 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v23.0.0 milestone Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.70%. Comparing base (bee41a6) to head (e2f85d2).
⚠️ Report is 3 commits behind head on release-23.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.0   #18859   +/-   ##
=============================================
  Coverage         69.70%   69.70%           
=============================================
  Files              1606     1606           
  Lines            214482   214482           
=============================================
+ Hits             149494   149501    +7     
+ Misses            64988    64981    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@systay systay mentioned this pull request Nov 4, 2025
44 tasks
@systay systay modified the milestones: v23.0.0, v23.0.1 Nov 4, 2025
#18852)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
@nickvanw nickvanw force-pushed the backport-18852-to-release-23.0 branch from 171bfa3 to e2f85d2 Compare November 4, 2025 15:50
@nickvanw nickvanw enabled auto-merge (squash) November 4, 2025 15:51
@nickvanw nickvanw merged commit 72d2849 into release-23.0 Nov 4, 2025
102 of 107 checks passed
@nickvanw nickvanw deleted the backport-18852-to-release-23.0 branch November 4, 2025 17:04
timvaillancourt pushed a commit that referenced this pull request Nov 4, 2025
…inary for lastpk (#18852) (#18859)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…inary for lastpk (vitessio#18852) (vitessio#18859)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…inary for lastpk (vitessio#18852) (vitessio#18859)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…inary for lastpk (vitessio#18852) (vitessio#18859)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
…inary for lastpk (vitessio#18852) (vitessio#18859)

Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants