Skip to content

[release-21.0] Address dir traversal in file backup storage GetBackups RPC (#18814) - #18816

Merged
timvaillancourt merged 3 commits into
release-21.0from
backport-18814-to-release-21.0
Oct 28, 2025
Merged

[release-21.0] Address dir traversal in file backup storage GetBackups RPC (#18814)#18816
timvaillancourt merged 3 commits into
release-21.0from
backport-18814-to-release-21.0

force ci

9eaefbf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2025 in 0s

69.88% (+0.01%) compared to 432ac4a

View this Pull Request on Codecov

69.88% (+0.01%) compared to 432ac4a

Details

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.88%. Comparing base (432ac4a) to head (9eaefbf).

Files with missing lines Patch % Lines
go/vt/mysqlctl/filebackupstorage/file.go 73.33% 4 Missing ⚠️
go/fileutil/join.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #18816      +/-   ##
================================================
+ Coverage         69.86%   69.88%   +0.01%     
================================================
  Files              1572     1573       +1     
  Lines            204889   204911      +22     
================================================
+ Hits             143151   143199      +48     
+ Misses            61738    61712      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.