Skip to content

[release-23.0] Potential fix for code scanning alert no. 2992: Clear-text logging of sensitive information (#18754)#18760

Merged
systay merged 1 commit intorelease-23.0from
backport-18754-to-release-23.0
Oct 27, 2025
Merged

[release-23.0] Potential fix for code scanning alert no. 2992: Clear-text logging of sensitive information (#18754)#18760
systay merged 1 commit intorelease-23.0from
backport-18754-to-release-23.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 16, 2025

Description

This is a backport of #18754

… sensitive information (#18754)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v23.0.0 milestone Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.51%. Comparing base (eab5c0d) to head (206c52e).
⚠️ Report is 7 commits behind head on release-23.0.

Files with missing lines Patch % Lines
go/cmd/vtctldclient/command/permissions.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #18760      +/-   ##
================================================
- Coverage         67.53%   67.51%   -0.03%     
================================================
  Files              1605     1605              
  Lines            263808   263814       +6     
================================================
- Hits             178164   178104      -60     
- Misses            85644    85710      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvaillancourt timvaillancourt enabled auto-merge (squash) October 16, 2025 21:07
@systay systay mentioned this pull request Oct 17, 2025
52 tasks
@systay systay merged commit 1fc8a1e into release-23.0 Oct 27, 2025
108 of 121 checks passed
@systay systay deleted the backport-18754-to-release-23.0 branch October 27, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants