Skip to content

[release-21.0] Fix handling of tuple bind variables in filtering operations. (#18736)#18745

Merged
arthurschreiber merged 1 commit intorelease-21.0from
backport-18736-to-release-21.0
Oct 15, 2025
Merged

[release-21.0] Fix handling of tuple bind variables in filtering operations. (#18736)#18745
arthurschreiber merged 1 commit intorelease-21.0from
backport-18736-to-release-21.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 14, 2025

Description

This is a backport of #18736

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot vitess-bot bot requested a review from dbussink as a code owner October 14, 2025 19:00
@vitess-bot vitess-bot bot requested a review from systay as a code owner October 14, 2025 19:00
@vitess-bot vitess-bot bot added the Type: Bug label Oct 14, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 14, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.6 milestone Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.53%. Comparing base (e5e8a58) to head (b9e6165).
⚠️ Report is 1 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/compiler_asm_push.go 76.47% 4 Missing ⚠️
go/vt/vtgate/evalengine/expr_compare.go 60.00% 4 Missing ⚠️
go/vt/vtgate/evalengine/eval_tuple.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-21.0   #18745   +/-   ##
=============================================
  Coverage         67.52%   67.53%           
=============================================
  Files              1572     1572           
  Lines            252536   252576   +40     
=============================================
+ Hits             170531   170573   +42     
+ Misses            82005    82003    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit aee86b4 into release-21.0 Oct 15, 2025
105 of 109 checks passed
@arthurschreiber arthurschreiber deleted the backport-18736-to-release-21.0 branch October 15, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants