[release-21.0] Backport: Fix GetSchema RPC to prevent returning view definitions when EnableViews is disabled#18734
Merged
harshit-gangal merged 2 commits intovitessio:release-21.0from Oct 10, 2025
Conversation
…ews is disabled (vitessio#18513) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #18734 +/- ##
================================================
- Coverage 67.55% 67.54% -0.02%
================================================
Files 1572 1572
Lines 252526 252536 +10
================================================
- Hits 170596 170571 -25
- Misses 81930 81965 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
rohit-nayak-ps
approved these changes
Oct 10, 2025
systay
approved these changes
Oct 10, 2025
e5e8a58
into
vitessio:release-21.0
100 of 102 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is backport of #18513