Skip to content

[release-22.0] Upgrade the Golang version to go1.24.8#18726

Closed
vitess-bot wants to merge 1 commit intorelease-22.0from
upgrade-go-to-1.24.8-on-release-22.0
Closed

[release-22.0] Upgrade the Golang version to go1.24.8#18726
vitess-bot wants to merge 1 commit intorelease-22.0from
upgrade-go-to-1.24.8-on-release-22.0

Conversation

@vitess-bot
Copy link
Contributor

This Pull Request bumps the Golang version to go1.24.8 and the bootstrap version to 43.4.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.

cc @vitessio/release

@vitess-bot vitess-bot added the Benchmark me Add label to PR to run benchmarks label Oct 8, 2025
@vitess-bot vitess-bot added Component: General Changes throughout the code base go labels Oct 8, 2025
@vitess-bot vitess-bot added Skip CI Skip CI actions from running Type: CI/Build Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go labels Oct 8, 2025
@vitess-bot vitess-bot requested a review from a team October 8, 2025 00:32
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 8, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 8, 2025

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 8, 2025
@github-actions github-actions bot added this to the v22.0.2 milestone Oct 8, 2025
@mattlord mattlord added Skip CI Skip CI actions from running and removed Skip CI Skip CI actions from running labels Oct 8, 2025
@nickvanw nickvanw force-pushed the upgrade-go-to-1.24.8-on-release-22.0 branch from 068d301 to 17128aa Compare October 27, 2025 08:23
@nickvanw nickvanw removed Skip CI Skip CI actions from running NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 27, 2025
@nickvanw nickvanw removed the Benchmark me Add label to PR to run benchmarks label Oct 27, 2025
@nickvanw nickvanw force-pushed the upgrade-go-to-1.24.8-on-release-22.0 branch from 17128aa to eeaae1f Compare October 27, 2025 08:24
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
@nickvanw nickvanw force-pushed the upgrade-go-to-1.24.8-on-release-22.0 branch from eeaae1f to 4d10a0c Compare October 27, 2025 08:37
@nickvanw
Copy link
Collaborator

closing this in favor of #18737

@nickvanw nickvanw closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants