Skip to content

[release-22.0] connpool: Bump the hang detection timeout to fix flakiness (#18722) #18724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurschreiber merged 1 commit into from
Oct 7, 2025
Merged

[release-22.0] connpool: Bump the hang detection timeout to fix flakiness (#18722) #18724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/pools/smartconnpool/pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@ func TestGetSpike(t *testing.T) {
func TestCloseDuringWaitForConn(t *testing.T) {
ctx := context.Background()
goRoutineCnt := 50
getTimeout := 300 * time.Millisecond
getTimeout := 2000 * time.Millisecond

for range 50 {
hung := make(chan (struct{}), goRoutineCnt)
Expand All @@ -1263,7 +1263,7 @@ func TestCloseDuringWaitForConn(t *testing.T) {
wg := sync.WaitGroup{}
var count atomic.Int64

fmt.Println("Starting TestCloseDuringGetAndPut")
fmt.Println("Starting TestCloseDuringWaitForConn")

// Spawn multiple goroutines to perform Get and Put operations, but only
// allow connections to be checked out until `closed` has been set to true.
Expand Down
Loading