[release-21.0] CONNPOOL: Fix race condition when waiting for connection (#18713)

[vitess-bot]

Description

This is a backport of #18713

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[vitess-bot]

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 18720 -R vitessio/vitess
git reset --hard origin/release-21.0
git cherry-pick -m 1 6ea0799f25baff73804bbeeaa9ec883145e082c9

[vitess-bot]

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

[codecov]

Codecov Report

❌ Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (24ef7cc) to head (2a063db).
⚠️ Report is 3 commits behind head on release-21.0.

Files with missing lines	Patch %	Lines
go/pools/smartconnpool/pool.go	81.48%	5 Missing ⚠️
go/pools/smartconnpool/waitlist.go	96.66%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-21.0   #18720      +/-   ##
================================================
- Coverage         67.54%   67.52%   -0.03%     
================================================
  Files              1572     1572              
  Lines            252474   252526      +52     
================================================
- Hits             170545   170525      -20     
- Misses            81929    82001      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.