Skip to content

connpool: Don't use go internal sema functionality - #18719

Merged
arthurschreiber merged 2 commits into
mainfrom
arthur/pool-dont-use-sema
Oct 8, 2025
Merged

connpool: Don't use go internal sema functionality#18719
arthurschreiber merged 2 commits into
mainfrom
arthur/pool-dont-use-sema

Merge branch 'main' of https://github.com/vitessio/vitess into arthur…

00fe4fe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2025 in 1s

67.50% (+0.00%) compared to 484183c

View this Pull Request on Codecov

67.50% (+0.00%) compared to 484183c

Details

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.50%. Comparing base (484183c) to head (00fe4fe).

Files with missing lines Patch % Lines
go/pools/smartconnpool/waitlist.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18719   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        1606     1605    -1     
  Lines      263773   263756   -17     
=======================================
- Hits       178048   178038   -10     
+ Misses      85725    85718    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.