Skip to content

[release-21.0] Simplify workflow files. (#18649)#18655

Merged
arthurschreiber merged 1 commit intorelease-21.0from
backport-18649-to-release-21.0
Sep 16, 2025
Merged

[release-21.0] Simplify workflow files. (#18649)#18655
arthurschreiber merged 1 commit intorelease-21.0from
backport-18649-to-release-21.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 16, 2025

Description

This is a backport of #18649

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Merge Conflict Skip CI Skip CI actions from running Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup labels Sep 16, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 16, 2025

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 18655 -R vitessio/vitess
git reset --hard origin/release-21.0
git cherry-pick -m 1 6d30034930e9000799bd95f1928506de957d137d

@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.6 milestone Sep 16, 2025
@arthurschreiber arthurschreiber force-pushed the backport-18649-to-release-21.0 branch from 750c44c to 117423a Compare September 16, 2025 05:50
@arthurschreiber arthurschreiber removed Skip CI Skip CI actions from running Merge Conflict labels Sep 16, 2025
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber arthurschreiber force-pushed the backport-18649-to-release-21.0 branch from 117423a to 42f6264 Compare September 16, 2025 05:52
@arthurschreiber arthurschreiber marked this pull request as ready for review September 16, 2025 05:53
@arthurschreiber arthurschreiber enabled auto-merge (squash) September 16, 2025 05:53
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.52%. Comparing base (ad0ac6c) to head (42f6264).
⚠️ Report is 1 commits behind head on release-21.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #18655      +/-   ##
================================================
- Coverage         67.53%   67.52%   -0.02%     
================================================
  Files              1572     1572              
  Lines            252474   252474              
================================================
- Hits             170515   170473      -42     
- Misses            81959    82001      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit de22552 into release-21.0 Sep 16, 2025
104 of 106 checks passed
@arthurschreiber arthurschreiber deleted the backport-18649-to-release-21.0 branch September 16, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants