Fix a panic in VDiff when reconciling extra rows. (#18585)

fcbc8e2

Select commit

Loading

Failed to load commit list.

Uh oh!

There was an error while loading. Please reload this page.

DCO

Codecov

codecov/patch

codecov/project

Cluster (vtgate_topo_etcd) on: push

Run endtoend tests on Cluster (vtgate_topo_etcd)

Cluster (vtgate_schema) on: push

Run endtoend tests on Cluster (vtgate_schema)

Cluster (15) on: push

Run endtoend tests on Cluster (15)

java_docker_test on: push

Java Docker Test

Cluster (tabletmanager_tablegc) on: push

Run endtoend tests on Cluster (tabletmanager_tablegc)

Cluster (onlineddl_vrepl) on: push

Run endtoend tests on Cluster (onlineddl_vrepl)

Cluster (xb_backup) on: push

Run endtoend tests on Cluster (xb_backup)

Query Serving (Schema) - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Schema)

local_example on: push

Local example using consul on Ubuntu

Local example using etcd on Ubuntu

Local example using zk2 on Ubuntu

Query Serving (Queries) Next Release - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Queries) Next Release

Cluster (vtgate_tablet_healthcheck_cache) on: push

Run endtoend tests on Cluster (vtgate_tablet_healthcheck_cache)

Cluster (vreplication_mariadb_to_mysql) on: push

Run endtoend tests on Cluster (vreplication_mariadb_to_mysql)

Vitess Tester (vtgate) on: push

Run endtoend tests on Vitess Tester (vtgate)

Reparent New Vtctl - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Reparent New Vtctl

Cluster (vtgate_transaction) on: push

Run endtoend tests on Cluster (vtgate_transaction)

Cluster (vreplication_vdiff2) on: push

Run endtoend tests on Cluster (vreplication_vdiff2)

Cluster (vtgate_readafterwrite) on: push

Run endtoend tests on Cluster (vtgate_readafterwrite)

Cluster (vtgate_reservedconn) on: push

Run endtoend tests on Cluster (vtgate_reservedconn)

Cluster (vreplication_foreign_key_stress) on: push

Run endtoend tests on Cluster (vreplication_foreign_key_stress)

Backups - Manual - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Backups - Manual

Reparent Old Vtctl - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Reparent Old Vtctl

Cluster (vtorc) on: push

Run endtoend tests on Cluster (vtorc)

Cluster (vtgate_unsharded) on: push

Run endtoend tests on Cluster (vtgate_unsharded)

Cluster (vtgate_queries) on: push

Run endtoend tests on Cluster (vtgate_queries)

Cluster (vtgate_topo_consul) on: push

Run endtoend tests on Cluster (vtgate_topo_consul)

docker_test_cluster on: push

Docker Test Cluster

Cluster (12) on: push

Run endtoend tests on Cluster (12)

Cluster (tabletmanager_consul) on: push

Run endtoend tests on Cluster (tabletmanager_consul)

Unit Test (mysql84) on: push

Unit Test (mysql84)

Cluster (vtctlbackup_sharded_clustertest_heavy) on: push

Run endtoend tests on Cluster (vtctlbackup_sharded_clustertest_heavy)

Cluster (vreplication_migrate) on: push

Run endtoend tests on Cluster (vreplication_migrate)

Cluster (21) on: push

Run endtoend tests on Cluster (21)

Cluster (mysql80) on: push

Run endtoend tests on Cluster (mysql80)

Cluster (vtgate_godriver) on: push

Run endtoend tests on Cluster (vtgate_godriver)

Cluster (vtgate_concurrentdml) on: push

Run endtoend tests on Cluster (vtgate_concurrentdml)

Cluster (vreplication_copy_parallel) on: push

Run endtoend tests on Cluster (vreplication_copy_parallel)

Cluster (vtgate_partial_keyspace) on: push

Run endtoend tests on Cluster (vtgate_partial_keyspace)

Query Serving (Schema) Next Release - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Schema) Next Release

Cluster (vtgate_general_heavy) on: push

Run endtoend tests on Cluster (vtgate_general_heavy)

endtoend on: push

End-to-End Test

Cluster (ers_prs_newfeatures_heavy) on: push

Run endtoend tests on Cluster (ers_prs_newfeatures_heavy)

Cluster (onlineddl_scheduler) on: push

Run endtoend tests on Cluster (onlineddl_scheduler)

Cluster (vtgate_schema_tracker) on: push

Run endtoend tests on Cluster (vtgate_schema_tracker)

Cluster (vreplication_v2) on: push

Run endtoend tests on Cluster (vreplication_v2)

Cluster (13) on: push

Run endtoend tests on Cluster (13)

Semi Sync Upgrade Downgrade Testing on: push

Run Semi Sync Upgrade Downgrade Test

Query Serving (Queries) - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Queries)

Unit Test (evalengine_mysql84) on: push

Unit Test (evalengine_mysql84)

Backups - Manual - Next Release - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Backups - Manual - Next Release

Cluster (vtgate_plantests) on: push

Run endtoend tests on Cluster (vtgate_plantests)

Unit Test (mysql80) on: push

Unit Test (mysql80)

Cluster (tabletmanager_throttler_topo) on: push

Run endtoend tests on Cluster (tabletmanager_throttler_topo)

e2e_race on: push

End-to-End Test (Race)

Cluster (vtgate_vindex_heavy) on: push

Run endtoend tests on Cluster (vtgate_vindex_heavy)

Cluster (vtgate_gen4) on: push

Run endtoend tests on Cluster (vtgate_gen4)

check_make_vtadmin_authz_testgen on: push

Check Make vtadmin_authz_testgen

Cluster (onlineddl_vrepl_stress_suite) on: push

Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite)

Cluster (vreplication_multi_tenant) on: push

Run endtoend tests on Cluster (vreplication_multi_tenant)

Cluster (vreplication_basic) on: push

Run endtoend tests on Cluster (vreplication_basic)

Cluster (backup_pitr_mysqlshell) on: push

Run endtoend tests on Cluster (backup_pitr_mysqlshell)

Cluster (onlineddl_revert) on: push

Run endtoend tests on Cluster (onlineddl_revert)

Code Coverage on: push 3

Code Coverage

vtop_example on: push

VTop Example

Unit Test (mysql57) on: push

Unit Test (mysql57)

Backups - E2E - Next Release - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Backups - E2E - Next Release

Cluster (vreplication_vtctldclient_movetables_tz) on: push

Run endtoend tests on Cluster (vreplication_vtctldclient_movetables_tz)

Cluster (vstream) on: push

Run endtoend tests on Cluster (vstream)

Cluster (topo_connection_cache) on: push

Run endtoend tests on Cluster (topo_connection_cache)

Cluster (vtgate_topo) on: push

Run endtoend tests on Cluster (vtgate_topo)

region_example on: push

Region Sharding example using etcd on Ubuntu

unit_race on: push

Unit Test (Race)

Cluster (vreplication_partial_movetables_and_materialize) on: push

Run endtoend tests on Cluster (vreplication_partial_movetables_and_materialize)

Cluster (vtbackup) on: push

Run endtoend tests on Cluster (vtbackup)

Query Serving (Queries - 2) Next Release - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Queries - 2) Next Release

Cluster (backup_pitr) on: push

Run endtoend tests on Cluster (backup_pitr)

Cluster (18) on: push

Run endtoend tests on Cluster (18)

Cluster (vtgate_foreignkey_stress) on: push

Run endtoend tests on Cluster (vtgate_foreignkey_stress)

Unit Test (evalengine_mysql80) on: push

Unit Test (evalengine_mysql80)

Cluster (onlineddl_vrepl_suite) on: push

Run endtoend tests on Cluster (onlineddl_vrepl_suite)

Cluster (vreplication_across_db_versions) on: push

Run endtoend tests on Cluster (vreplication_across_db_versions)

Cluster (onlineddl_vrepl_stress) on: push

Run endtoend tests on Cluster (onlineddl_vrepl_stress)

Backups - E2E - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Backups - E2E

Online DDL flow - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Online DDL flow

Unit Test (evalengine_mysql57) on: push

Unit Test (evalengine_mysql57)

Cluster (backup_pitr_xtrabackup) on: push

Run endtoend tests on Cluster (backup_pitr_xtrabackup)

Query Serving (Queries - 2) - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Query Serving (Queries - 2)

Cluster (vtgate_vschema) on: push

Run endtoend tests on Cluster (vtgate_vschema)

Reparent New VTTablet - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Reparent New VTTablet

Static Code Checks, Etc. on: push

Static Code Checks Etc

Cluster (xb_recovery) on: push

Run endtoend tests on Cluster (xb_recovery)

Cluster (schemadiff_vrepl) on: push

Run endtoend tests on Cluster (schemadiff_vrepl)

Reparent Old VTTablet - Upgrade Downgrade Testing on: push

Run Upgrade Downgrade Test - Reparent Old VTTablet

unit_race_evalengine on: push

Unit Test (Evalengine_Race)

Cluster (vttablet_prscomplex) on: push

Run endtoend tests on Cluster (vttablet_prscomplex)

Cluster (mysql_server_vault) on: push

Run endtoend tests on Cluster (mysql_server_vault)

Cluster (vreplication_cellalias) on: push

Run endtoend tests on Cluster (vreplication_cellalias)

check_make_vtadmin_web_proto on: push

Check Make VTAdmin Web Proto

Assign Milestone on: pull_request_target

Assign Milestone

Cluster (backup_pitr) on: pull_request 3

Run endtoend tests on Cluster (backup_pitr)

endtoend on: pull_request 2

End-to-End Test

Unit Test (evalengine_mysql80) on: pull_request 3

Unit Test (evalengine_mysql80)

Cluster (vreplication_vtctldclient_movetables_tz) on: pull_request 3

Run endtoend tests on Cluster (vreplication_vtctldclient_movetables_tz)

Cluster (schemadiff_vrepl) on: pull_request 3

Run endtoend tests on Cluster (schemadiff_vrepl)

Cluster (vtgate_schema) on: pull_request 3

Run endtoend tests on Cluster (vtgate_schema)

Cluster (vreplication_vdiff2) on: pull_request 3

Run endtoend tests on Cluster (vreplication_vdiff2)

Cluster (backup_pitr_mysqlshell) on: pull_request 3

Run endtoend tests on Cluster (backup_pitr_mysqlshell)

Reparent New VTTablet - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Reparent New VTTablet

Cluster (vtgate_topo_etcd) on: pull_request 3

Run endtoend tests on Cluster (vtgate_topo_etcd)

Cluster (onlineddl_vrepl_suite) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_vrepl_suite)

Reparent Old VTTablet - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Reparent Old VTTablet

unit_race on: pull_request 3

Unit Test (Race)

local_example on: pull_request 6

Local example using consul on Ubuntu

Local example using etcd on Ubuntu

Local example using zk2 on Ubuntu

Backups - E2E - Next Release - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Backups - E2E - Next Release

Cluster (vttablet_prscomplex) on: pull_request 3

Run endtoend tests on Cluster (vttablet_prscomplex)

Cluster (vreplication_v2) on: pull_request 3

Run endtoend tests on Cluster (vreplication_v2)

Query Serving (Schema) - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Schema)

Unit Test (evalengine_mysql84) on: pull_request 3

Unit Test (evalengine_mysql84)

Cluster (vreplication_foreign_key_stress) on: pull_request 3

Run endtoend tests on Cluster (vreplication_foreign_key_stress)

Cluster (vtgate_unsharded) on: pull_request 3

Run endtoend tests on Cluster (vtgate_unsharded)

Reparent New Vtctl - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Reparent New Vtctl

Backups - E2E - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Backups - E2E

Unit Test (mysql80) on: pull_request 3

Unit Test (mysql80)

Cluster (vreplication_cellalias) on: pull_request 3

Run endtoend tests on Cluster (vreplication_cellalias)

e2e_race on: pull_request 2

End-to-End Test (Race)

Cluster (vreplication_partial_movetables_and_materialize) on: pull_request 5

Run endtoend tests on Cluster (vreplication_partial_movetables_and_materialize)

vtop_example on: pull_request 2

VTop Example

Cluster (vtgate_general_heavy) on: pull_request 3

Run endtoend tests on Cluster (vtgate_general_heavy)

Backups - Manual - Next Release - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Backups - Manual - Next Release

Cluster (vtgate_topo_consul) on: pull_request 3

Run endtoend tests on Cluster (vtgate_topo_consul)

Cluster (vreplication_basic) on: pull_request 3

Run endtoend tests on Cluster (vreplication_basic)

Check Pull Request labels on: pull_request

Check Pull Request labels

Cluster (xb_recovery) on: pull_request 3

Run endtoend tests on Cluster (xb_recovery)

Cluster (vtgate_foreignkey_stress) on: pull_request 3

Run endtoend tests on Cluster (vtgate_foreignkey_stress)

Online DDL flow - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Online DDL flow

Cluster (onlineddl_vrepl_stress_suite) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite)

Cluster (vreplication_mariadb_to_mysql) on: pull_request 3

Run endtoend tests on Cluster (vreplication_mariadb_to_mysql)

Auto Approval of Bot Pull Requests on: pull_request

Auto Approve Pull Request

Cluster (vtgate_gen4) on: pull_request 3

Run endtoend tests on Cluster (vtgate_gen4)

check_make_vtadmin_authz_testgen on: pull_request

Check Make vtadmin_authz_testgen

Cluster (vtorc) on: pull_request 3

Run endtoend tests on Cluster (vtorc)

Reparent Old Vtctl - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Reparent Old Vtctl

Vitess Tester (vtgate) on: pull_request 3

Run endtoend tests on Vitess Tester (vtgate)

Cluster (mysql80) on: pull_request 3

Run endtoend tests on Cluster (mysql80)

Cluster (vtctlbackup_sharded_clustertest_heavy) on: pull_request 3

Run endtoend tests on Cluster (vtctlbackup_sharded_clustertest_heavy)

Cluster (vtgate_transaction) on: pull_request 3

Run endtoend tests on Cluster (vtgate_transaction)

Cluster (vstream) on: pull_request 3

Run endtoend tests on Cluster (vstream)

Cluster (vtgate_tablet_healthcheck_cache) on: pull_request 3

Run endtoend tests on Cluster (vtgate_tablet_healthcheck_cache)

region_example on: pull_request 2

Region Sharding example using etcd on Ubuntu

Cluster (vreplication_migrate) on: pull_request 3

Run endtoend tests on Cluster (vreplication_migrate)

Query Serving (Queries) - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Queries)

Cluster (vreplication_copy_parallel) on: pull_request 3

Run endtoend tests on Cluster (vreplication_copy_parallel)

Cluster (vtgate_partial_keyspace) on: pull_request 3

Run endtoend tests on Cluster (vtgate_partial_keyspace)

Code Freeze on: pull_request

Code Freeze

docker_test_cluster on: pull_request 2

Docker Test Cluster

Cluster (vtgate_topo) on: pull_request 3

Run endtoend tests on Cluster (vtgate_topo)

Query Serving (Queries - 2) Next Release - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Queries - 2) Next Release

Cluster (topo_connection_cache) on: pull_request 3

Run endtoend tests on Cluster (topo_connection_cache)

Cluster (vtgate_vindex_heavy) on: pull_request 3

Run endtoend tests on Cluster (vtgate_vindex_heavy)

Cluster (ers_prs_newfeatures_heavy) on: pull_request 3

Run endtoend tests on Cluster (ers_prs_newfeatures_heavy)

Unit Test (mysql57) on: pull_request 3

Unit Test (mysql57)

Unit Test (evalengine_mysql57) on: pull_request 3

Unit Test (evalengine_mysql57)

Unit Test (mysql84) on: pull_request 3

Unit Test (mysql84)

Cluster (mysql_server_vault) on: pull_request 3

Run endtoend tests on Cluster (mysql_server_vault)

Cluster (vreplication_multi_tenant) on: pull_request 3

Run endtoend tests on Cluster (vreplication_multi_tenant)

Cluster (onlineddl_scheduler) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_scheduler)

Cluster (18) on: pull_request 3

Run endtoend tests on Cluster (18)

Cluster (tabletmanager_tablegc) on: pull_request 3

Run endtoend tests on Cluster (tabletmanager_tablegc)

Cluster (vtgate_schema_tracker) on: pull_request 3

Run endtoend tests on Cluster (vtgate_schema_tracker)

Semi Sync Upgrade Downgrade Testing on: pull_request 3

Run Semi Sync Upgrade Downgrade Test

java_docker_test on: pull_request 2

Java Docker Test

Cluster (vtgate_queries) on: pull_request 3

Run endtoend tests on Cluster (vtgate_queries)

Cluster (vtbackup) on: pull_request 3

Run endtoend tests on Cluster (vtbackup)

Query Serving (Queries - 2) - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Queries - 2)

Query Serving (Schema) Next Release - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Schema) Next Release

Cluster (21) on: pull_request 3

Run endtoend tests on Cluster (21)

Cluster (vtgate_concurrentdml) on: pull_request 3

Run endtoend tests on Cluster (vtgate_concurrentdml)

Cluster (backup_pitr_xtrabackup) on: pull_request 3

Run endtoend tests on Cluster (backup_pitr_xtrabackup)

Static Code Checks, Etc. on: pull_request 2

Static Code Checks Etc

Cluster (onlineddl_vrepl) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_vrepl)

Query Serving (Queries) Next Release - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Query Serving (Queries) Next Release

Cluster (onlineddl_vrepl_stress) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_vrepl_stress)

Cluster (13) on: pull_request 3

Run endtoend tests on Cluster (13)

Code Coverage on: pull_request 3

Code Coverage

Cluster (vtgate_vschema) on: pull_request 3

Run endtoend tests on Cluster (vtgate_vschema)

Cluster (vtgate_plantests) on: pull_request 3

Run endtoend tests on Cluster (vtgate_plantests)

unit_race_evalengine on: pull_request 3

Unit Test (Evalengine_Race)

Cluster (vtgate_readafterwrite) on: pull_request 3

Run endtoend tests on Cluster (vtgate_readafterwrite)

Cluster (15) on: pull_request 3

Run endtoend tests on Cluster (15)

Cluster (tabletmanager_throttler_topo) on: pull_request 3

Run endtoend tests on Cluster (tabletmanager_throttler_topo)

Cluster (vtgate_reservedconn) on: pull_request 3

Run endtoend tests on Cluster (vtgate_reservedconn)

Cluster (vreplication_across_db_versions) on: pull_request 3

Run endtoend tests on Cluster (vreplication_across_db_versions)

Cluster (vtgate_godriver) on: pull_request 3

Run endtoend tests on Cluster (vtgate_godriver)

check_make_vtadmin_web_proto on: pull_request

Check Make VTAdmin Web Proto

Backups - Manual - Upgrade Downgrade Testing on: pull_request 3

Run Upgrade Downgrade Test - Backups - Manual

Cluster (xb_backup) on: pull_request 3

Run endtoend tests on Cluster (xb_backup)

Cluster (tabletmanager_consul) on: pull_request 3

Run endtoend tests on Cluster (tabletmanager_consul)

Cluster (onlineddl_revert) on: pull_request 3

Run endtoend tests on Cluster (onlineddl_revert)

Cluster (12) on: pull_request 3

Run endtoend tests on Cluster (12)

Check Pull Request labels on: pull_request

Check Pull Request labels

Check Pull Request labels on: pull_request

Check Pull Request labels

Check Pull Request labels on: pull_request

Check Pull Request labels

Check Pull Request labels on: pull_request

Check Pull Request labels

DCO / DCO succeeded Aug 28, 2025 in 1s

DCO

All commits are signed off!

View more details on DCO

Loading

Fix a panic in VDiff when reconciling extra rows. (#18585)

Uh oh!

DCO

Re-running checks...