Skip to content

VReplication: permission check logic on external tablets -- switch to a more practical solution - #18580

Merged
rohit-nayak-ps merged 8 commits into
vitessio:mainfrom
planetscale:rohit/reverse-repl-perms
Sep 22, 2025
Merged

VReplication: permission check logic on external tablets -- switch to a more practical solution#18580
rohit-nayak-ps merged 8 commits into
vitessio:mainfrom
planetscale:rohit/reverse-repl-perms

Add another test case, and fix up comments.

1a6be3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2025 in 1s

67.47% (-0.06%) compared to c024fff

View this Pull Request on Codecov

67.47% (-0.06%) compared to c024fff

Details

Codecov Report

❌ Patch coverage is 0% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.47%. Comparing base (c024fff) to head (1a6be3f).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_vreplication.go 0.00% 68 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 0.00% 2 Missing ⚠️
go/vt/mysqlctl/mysqld.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18580      +/-   ##
==========================================
- Coverage   67.53%   67.47%   -0.06%     
==========================================
  Files        1613     1613              
  Lines      263780   263962     +182     
==========================================
- Hits       178144   178119      -25     
- Misses      85636    85843     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.