Skip to content

tabletmanager/grpctmclient: use vtrpcpb/gRPC error codes#18565

Merged
timvaillancourt merged 5 commits into
vitessio:mainfrom
timvaillancourt:sqlerror-vterror-code-ers
Sep 13, 2025
Merged

tabletmanager/grpctmclient: use vtrpcpb/gRPC error codes#18565
timvaillancourt merged 5 commits into
vitessio:mainfrom
timvaillancourt:sqlerror-vterror-code-ers

update comment

e2a92d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 13, 2025 in 0s

67.51% (+0.00%) compared to 2fb4fa7

View this Pull Request on Codecov

67.51% (+0.00%) compared to 2fb4fa7

Details

Codecov Report

❌ Patch coverage is 53.33333% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.51%. Comparing base (2fb4fa7) to head (e2a92d2).

Files with missing lines Patch % Lines
go/vt/vttablet/grpctmclient/client.go 64.55% 28 Missing ⚠️
go/mysql/sqlerror/sql_error.go 22.85% 27 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_server.go 37.50% 5 Missing ⚠️
go/vt/vttablet/tabletserver/throttle/throttler.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18565   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files        1607     1607           
  Lines      263548   263567   +19     
=======================================
+ Hits       177941   177958   +17     
- Misses      85607    85609    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.