Skip to content

EmergencyReparentShard: include SQL thread position in most-advanced candidate selection #18531

Merged
timvaillancourt merged 6 commits into
vitessio:mainfrom
timvaillancourt:reparentutil-sorter-sqlExec
Sep 30, 2025
Merged

EmergencyReparentShard: include SQL thread position in most-advanced candidate selection #18531
timvaillancourt merged 6 commits into
vitessio:mainfrom
timvaillancourt:reparentutil-sorter-sqlExec

Merge remote-tracking branch 'origin/main' into reparentutil-sorter-s…

614da3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 28, 2025 in 0s

67.52% (+0.02%) compared to 6b4fa3d

View this Pull Request on Codecov

67.52% (+0.02%) compared to 6b4fa3d

Details

Codecov Report

❌ Patch coverage is 86.88525% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (6b4fa3d) to head (614da3f).

Files with missing lines Patch % Lines
go/vt/vtctl/reparentutil/replication.go 82.60% 4 Missing ⚠️
go/vt/vtctl/reparentutil/util.go 83.33% 3 Missing ⚠️
go/vt/vtctl/reparentutil/emergency_reparenter.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18531      +/-   ##
==========================================
+ Coverage   67.50%   67.52%   +0.02%     
==========================================
  Files        1608     1608              
  Lines      263594   263624      +30     
==========================================
+ Hits       177931   178004      +73     
+ Misses      85663    85620      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.