Skip to content

Set up better dependency checks#18508

Merged
dbussink merged 1 commit intovitessio:mainfrom
planetscale:dbussink/setup-better-dependency-checks
Jul 28, 2025
Merged

Set up better dependency checks#18508
dbussink merged 1 commit intovitessio:mainfrom
planetscale:dbussink/setup-better-dependency-checks

Conversation

@dbussink
Copy link
Member

In order to avoid future regressions around some key areas used as libraries, let's make sure we have some depguard checks in place that block some regularly occuring cases.

This is not green until we merge the regression from v22 in #18507

It also fixes one violation which is not as problematic as #18507 and has existed for longer already, so it's ok to only fix that on main moving forward.

Related Issue(s)

Part of fixing #18506 and important for #14717

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 28, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 28, 2025
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 28, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.49%. Comparing base (21df269) to head (46bc156).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/cmd/vtgate/cli/plugin_auth_clientcert.go 0.00% 3 Missing ⚠️
go/vt/vtgate/plugin_mysql_server.go 0.00% 2 Missing ⚠️
go/mysql/auth_server_clientcert.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18508   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        1607     1607           
  Lines      263045   263046    +1     
=======================================
+ Hits       177540   177545    +5     
+ Misses      85505    85501    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

In order to avoid future regressions around some key areas used as
libraries, let's make sure we have some depguard checks in place that
block some regularly occuring cases.

This is not green until we merge the regression from v22.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/setup-better-dependency-checks branch from ebf7045 to 46bc156 Compare July 28, 2025 11:17
@dbussink dbussink merged commit 22f9190 into vitessio:main Jul 28, 2025
102 of 107 checks passed
@dbussink dbussink deleted the dbussink/setup-better-dependency-checks branch July 28, 2025 14:08
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
…rds-new2

* origin/master:
  Set up better dependency checks (vitessio#18508)
  bugfix: Plan group by only on top of derived tables correctly (vitessio#18505)
  Fix regression in v22 around new flag setup (vitessio#18507)
  Bump form-data from 4.0.1 to 4.0.4 in /web/vtadmin (vitessio#18473)
  Bump @babel/runtime from 7.26.0 to 7.27.6 in /web/vtadmin (vitessio#18467)
  Bump vite from 4.5.9 to 4.5.14 in /web/vtadmin (vitessio#18485)
  Fix for simple projection showing no fields (vitessio#18489)
  log.Info -> log.Infof in tabletserver for reloading ACLs (vitessio#18461)
  Fix scalar aggregation with literals in empty result sets (vitessio#18477)
  Avoid terminating atomic copy workflows on error if they are out of copy phase (vitessio#18475)
  Update runners to use cncf oracle vms (vitessio#18425)
  fix: handle aliases in UNIONs better (vitessio#18484)
  VReplication: Fix bug while reading _vt.vreplication record (vitessio#18478)
  Planner: Add comprehensive debug logging for query planner NoRewrite cases (vitessio#18476)
  Update email in Maintainers file (vitessio#18472)
  tablet manager's `ExecuteFetchAsDba` does not allow multiple queries (vitessio#18183)

Signed-off-by: Morgan Tocker <tocker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants