Skip to content

[release-21.0] Fix scalar aggregation with literals in empty result sets (#18477)#18490

Merged
systay merged 1 commit intorelease-21.0from
backport-18477-to-release-21.0
Jul 29, 2025
Merged

[release-21.0] Fix scalar aggregation with literals in empty result sets (#18477)#18490
systay merged 1 commit intorelease-21.0from
backport-18477-to-release-21.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 25, 2025

Description

This is a backport of #18477

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Jul 25, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 25, 2025

Hello @systay, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 18490 -R vitessio/vitess
git reset --hard origin/release-21.0
git cherry-pick -m 1 51fc97722a4a8c7fd813d05f69c9959985413eb3

@vitess-bot vitess-bot bot added Component: Query Serving Backport This is a backport Skip CI Skip CI actions from running Merge Conflict labels Jul 25, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 25, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink removed Skip CI Skip CI actions from running Merge Conflict labels Jul 29, 2025
@dbussink dbussink marked this pull request as ready for review July 29, 2025 06:41
@dbussink dbussink force-pushed the backport-18477-to-release-21.0 branch from 2dd34cc to ded0296 Compare July 29, 2025 06:41
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 78.83598% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.55%. Comparing base (802a88c) to head (ded0296).
⚠️ Report is 2 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/vtgate/engine/aggregations.go 70.83% 21 Missing ⚠️
go/vt/vtgate/engine/ordered_aggregate.go 70.37% 8 Missing ⚠️
go/vt/vtgate/engine/scalar_aggregation.go 64.70% 6 Missing ⚠️
go/vt/vtgate/planbuilder/operators/aggregator.go 80.00% 3 Missing ⚠️
go/vt/vtgate/planbuilder/operator_transformers.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #18490      +/-   ##
================================================
+ Coverage         67.51%   67.55%   +0.03%     
================================================
  Files              1572     1572              
  Lines            252358   252463     +105     
================================================
+ Hits             170390   170544     +154     
+ Misses            81968    81919      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@systay systay merged commit efbcac5 into release-21.0 Jul 29, 2025
195 of 196 checks passed
@systay systay deleted the backport-18477-to-release-21.0 branch July 29, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants