Skip to content

[release-20.0] Fix vttablet not being marked as not serving when MySQL stalls (#17883)#18452

Merged
timvaillancourt merged 1 commit intorelease-20.0from
backport-17883-to-release-20.0
Jul 16, 2025
Merged

[release-20.0] Fix vttablet not being marked as not serving when MySQL stalls (#17883)#18452
timvaillancourt merged 1 commit intorelease-20.0from
backport-17883-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 16, 2025

Description

This is a backport of #17883

)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from arthurschreiber July 16, 2025 16:12
@github-actions github-actions bot added this to the v20.0.9 milestone Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (a4a6ed3) to head (22140b9).
Report is 1 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/repltracker/reader.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-20.0   #18452       +/-   ##
=================================================
+ Coverage              0   66.42%   +66.42%     
=================================================
  Files                 0     1543     +1543     
  Lines                 0   244949   +244949     
=================================================
+ Hits                  0   162696   +162696     
- Misses                0    82253    +82253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvaillancourt timvaillancourt self-requested a review July 16, 2025 23:30
@timvaillancourt timvaillancourt merged commit 343e7eb into release-20.0 Jul 16, 2025
190 of 191 checks passed
@timvaillancourt timvaillancourt deleted the backport-17883-to-release-20.0 branch July 16, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant