Add TabletType to prometheus vttablet_tablet_server_stat…

[jdoupe]

…e metric as type label

Description

This just adds TabletType, TabletKeyspace, and TabletShard labels to the vttablet_tablet_server_state metric. These pieces of information are available via /debug/vars but were never included in the prometheus output. Creating separate metrics for them seemed frivolous/wasteful, and therefore just added to a metric that is purely informational.

Related Issue(s)

Fixes #14300

Checklist

• [?] "Backport to:" labels have been added if this change should be back-ported to release branches
• [?] If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• [ n/a ] Did the new or modified tests pass consistently locally and on CI?
• [?] Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[jdoupe]

I rebased this in hopes that the checks would kick off clean (and to make sure all was right with the world), but I guess all that really accomplished was to reset the need for the workflow to be reapproved. ( @harshit-gangal )

[codecov]

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.49%. Comparing base (eab8588) to head (179c918).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletserver/tabletserver.go	9.09%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18451      +/-   ##
==========================================
- Coverage   67.50%   67.49%   -0.01%     
==========================================
  Files        1607     1607              
  Lines      263144   263153       +9     
==========================================
- Hits       177644   177627      -17     
- Misses      85500    85526      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.