Skip to content

[release-21.0] fix: keep LIMIT/OFFSET even when merging UNION queries (#18361)#18362

Merged
systay merged 2 commits intorelease-21.0from
backport-18361-to-release-21.0
Jun 16, 2025
Merged

[release-21.0] fix: keep LIMIT/OFFSET even when merging UNION queries (#18361)#18362
systay merged 2 commits intorelease-21.0from
backport-18361-to-release-21.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Jun 16, 2025

Description

This is a backport of #18361

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Jun 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.5 milestone Jun 16, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit ec6b87d into release-21.0 Jun 16, 2025
191 of 193 checks passed
@systay systay deleted the backport-18361-to-release-21.0 branch June 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant