Skip to content

VStreamer: change in filter logic - #18319

Merged
rohit-nayak-ps merged 9 commits into
vitessio:mainfrom
planetscale:rohit/filter-rows-no-partial
Jul 8, 2025
Merged

VStreamer: change in filter logic#18319
rohit-nayak-ps merged 9 commits into
vitessio:mainfrom
planetscale:rohit/filter-rows-no-partial

Address review comment

368d7ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 7, 2025 in 1s

67.50% (+0.01%) compared to b111270

View this Pull Request on Codecov

67.50% (+0.01%) compared to b111270

Details

Codecov Report

Attention: Patch coverage is 73.80952% with 22 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (b111270) to head (368d7ec).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletserver/vstreamer/vstreamer.go 75.00% 13 Missing ⚠️
.../vt/vttablet/tabletserver/vstreamer/planbuilder.go 69.23% 8 Missing ⚠️
.../vt/vttablet/tabletserver/vstreamer/rowstreamer.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18319      +/-   ##
==========================================
+ Coverage   67.49%   67.50%   +0.01%     
==========================================
  Files        1603     1607       +4     
  Lines      262426   262736     +310     
==========================================
+ Hits       177112   177368     +256     
- Misses      85314    85368      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.