Refactor vtcombo flags - Part 3

[mounicasruthi]

Description

This PR is a part of an ongoing change to support the transition from underscores (_) to dashes (-) in flag naming conventions. This PR refactors some flags specific to vtcombo binary.

Flags Updated in This PR:
--migration-check-interval
--lock-tables-timeout
--keyspaces-to-watch
--foreign-key-mode
--ddl-strategy
--allowed-tablet-types
--app-idle-timeout
--app-pool-size
--binlog-player-protocol
--dbddl-plugin
--degraded-threshold
--enforce-strict-trans-tables
--gate-query-cache-memory
--init-timeout
--json-topo
--lock-heartbeat-time
--max-concurrent-online-ddl
--max-memory-rows
--max-payload-size
--message-stream-grace-period
--mysqlctl-mycnf-template
--mysqlctl-socket
--no-scatter
--normalize-queries
--proto-topo
--proxy-protocol
--publish-retry-interval
--queryserver-enable-online-ddl

Flag Count Before vs After:

	Flags with _	Flags with -
Before	262	1816
After	193	1885

# of migrated flags: 69

Related Issue(s)

#17880

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (fcfa0c8) to head (b379f43).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtgate/vtgate.go	0.00%	11 Missing ⚠️
go/cmd/vtcombo/cli/main.go	0.00%	2 Missing ⚠️
go/vt/discovery/healthcheck.go	0.00%	2 Missing ⚠️
go/vt/mysqlctl/mysqld.go	80.00%	1 Missing ⚠️
go/vt/schemamanager/tablet_executor.go	0.00%	1 Missing ⚠️
go/vt/vtctl/vtctl.go	0.00%	1 Missing ⚠️
go/vt/vtgate/plugin_mysql_server.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18298      +/-   ##
==========================================
- Coverage   67.48%   67.47%   -0.01%     
==========================================
  Files        1603     1603              
  Lines      262337   262391      +54     
==========================================
+ Hits       177034   177045      +11     
- Misses      85303    85346      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[deepthi]

The description needs to be updated with flag counts.