Skip to content

Refactor vtcombo flags - Part 2 #18297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
May 28, 2025
Merged

Refactor vtcombo flags - Part 2 #18297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions config/tablet/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ oltp:
warnRows: 0 # queryserver-config-warn-result-size

healthcheck:
intervalSeconds: 20 # health_check_interval
intervalSeconds: 20 # health-check-interval
degradedThresholdSeconds: 30 # degraded_threshold
unhealthyThresholdSeconds: 7200 # unhealthy_threshold

Expand All @@ -92,15 +92,15 @@ replicationTracker:
hotRowProtection:
mode: disable|dryRun|enable # enable-hot-row-protection, enable-hot-row-protection-dry-run
# Recommended value: same as txPool.size.
maxQueueSize: 20 # hot_row_protection_max_queue_size
maxGlobalQueueSize: 1000 # hot_row_protection_max_global_queue_size
maxConcurrency: 5 # hot_row_protection_concurrent_transactions
maxQueueSize: 20 # hot-row-protection-max-queue-size
maxGlobalQueueSize: 1000 # hot-row-protection-max-global-queue-size
maxConcurrency: 5 # hot-row-protection-concurrent-transactions

consolidator: enable|disable|notOnPrimary # enable-consolidator, enable-consolidator-replicas
passthroughDML: false # queryserver-config-passthrough-dmls
streamBufferSize: 32768 # queryserver-config-stream-buffer-size
schemaReloadIntervalSeconds: 1800 # queryserver-config-schema-reload-time
watchReplication: false # watch_replication_stream
watchReplication: false # watch-replication-stream
terseErrors: false # queryserver-config-terse-errors
truncateErrorLen: 0 # queryserver-config-truncate-error-len
messagePostponeParallelism: 4 # queryserver-config-message-postpone-cap
Expand All @@ -117,8 +117,8 @@ messagePostponeParallelism: 4 # queryserver-config-message-postpone-c
# tx-throttler-tablet-types
# enable-transaction-limit
# enable-transaction-limit-dry-run
# transaction_limit_per_user
# transaction_limit_by_username
# transaction_limit_by_principal
# transaction_limit_by_component
# transaction_limit_by_subcomponent
# transaction-limit-per-user
# transaction-limit-by-username
# transaction-limit-by-principal
# transaction-limit-by-component
# transaction-limit-by-subcomponent
4 changes: 2 additions & 2 deletions examples/operator/401_scheduled_backups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ spec:
vttablet:
extraFlags:
db-charset: utf8mb4
wait_for_backup_interval: "0"
wait-for-backup-interval: "0"
resources:
limits:
memory: 1024Mi
Expand Down Expand Up @@ -168,7 +168,7 @@ spec:
vttablet:
extraFlags:
db-charset: utf8mb4
wait_for_backup_interval: "0"
wait-for-backup-interval: "0"
resources:
limits:
memory: 1024Mi
Expand Down
2 changes: 1 addition & 1 deletion go/flags/endtoend/vtbackup.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ Flags:
--v Level log level for V logs
-v, --version print binary version
--vmodule vModuleFlag comma-separated list of pattern=N settings for file-filtered logging
--xbstream_restore_flags string Flags to pass to xbstream command during restore. These should be space separated and will be added to the end of the command. These need to match the ones used for backup e.g. --compress / --decompress, --encrypt / --decrypt
--xbstream-restore-flags string Flags to pass to xbstream command during restore. These should be space separated and will be added to the end of the command. These need to match the ones used for backup e.g. --compress / --decompress, --encrypt / --decrypt
--xtrabackup-backup-flags string Flags to pass to backup command. These should be space separated and will be added to the end of the command
--xtrabackup-prepare-flags string Flags to pass to prepare command. These should be space separated and will be added to the end of the command
--xtrabackup-root-path string Directory location of the xtrabackup and xbstream executables, e.g., /usr/bin
Expand Down
54 changes: 27 additions & 27 deletions go/flags/endtoend/vtcombo.txt
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions go/flags/endtoend/vtgate.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ Flags:
--balancer-keyspaces strings When in balanced mode, a comma-separated list of keyspaces for which to use the balancer (optional)
--balancer-vtgate-cells strings When in balanced mode, a comma-separated list of cells that contain vtgates (required)
--bind-address string Bind address for the server. If empty, the server will listen on all available unicast and anycast IP addresses of the local system.
--buffer_drain_concurrency int Maximum number of requests retried simultaneously. More concurrency will increase the load on the PRIMARY vttablet when draining the buffer. (default 1)
--buffer_keyspace_shards string If not empty, limit buffering to these entries (comma separated). Entry format: keyspace or keyspace/shard. Requires --enable_buffer=true.
--buffer_max_failover_duration duration Stop buffering completely if a failover takes longer than this duration. (default 20s)
--buffer_min_time_between_failovers duration Minimum time between the end of a failover and the start of the next one (tracked per shard). Faster consecutive failovers will not trigger buffering. (default 1m0s)
--buffer_size int Maximum number of buffered requests in flight (across all ongoing failovers). (default 1000)
--buffer_window duration Duration for how long a request should be buffered at most. (default 10s)
--buffer-drain-concurrency int Maximum number of requests retried simultaneously. More concurrency will increase the load on the PRIMARY vttablet when draining the buffer. (default 1)
--buffer-keyspace-shards string If not empty, limit buffering to these entries (comma separated). Entry format: keyspace or keyspace/shard. Requires --enable_buffer=true.
--buffer-max-failover-duration duration Stop buffering completely if a failover takes longer than this duration. (default 20s)
--buffer-min-time-between-failovers duration Minimum time between the end of a failover and the start of the next one (tracked per shard). Faster consecutive failovers will not trigger buffering. (default 1m0s)
--buffer-size int Maximum number of buffered requests in flight (across all ongoing failovers). (default 1000)
--buffer-window duration Duration for how long a request should be buffered at most. (default 10s)
--catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified
--cell string cell to use
--cells_to_watch string comma-separated list of cells for watching tablets
Expand Down Expand Up @@ -99,8 +99,8 @@ Flags:
--grpc-use-effective-callerid If set, and SSL is not used, will set the immediate caller id from the effective caller id's principal.
--grpc-use-effective-groups If set, and SSL is not used, will set the immediate caller's security groups from the effective caller id's groups.
--grpc-use-static-authentication-callerid If set, will set the immediate caller id to the username authenticated by the static auth plugin.
--healthcheck_retry_delay duration health check retry delay (default 2ms)
--healthcheck_timeout duration the health check timeout period (default 1m0s)
--healthcheck-retry-delay duration health check retry delay (default 2ms)
--healthcheck-timeout duration the health check timeout period (default 1m0s)
-h, --help help for vtgate
--jaeger-agent-host string host and port to send spans to. if empty, no tracing will be done
--keep-logs duration keep logs for this long (using ctime) (zero to keep forever)
Expand Down Expand Up @@ -246,6 +246,6 @@ Flags:
--warming-reads-concurrency int Number of concurrent warming reads allowed (default 500)
--warming-reads-percent int Percentage of reads on the primary to forward to replicas. Useful for keeping buffer pools warm
--warming-reads-query-timeout duration Timeout of warming read queries (default 5s)
--warn_memory_rows int Warning threshold for in-memory results. A row count higher than this amount will cause the VtGateWarnings.ResultsExceeded counter to be incremented. (default 30000)
--warn_payload_size int The warning threshold for query payloads in bytes. A payload greater than this threshold will cause the VtGateWarnings.WarnPayloadSizeExceeded counter to be incremented.
--warn_sharded_only If any features that are only available in unsharded mode are used, query execution warnings will be added to the session
--warn-memory-rows int Warning threshold for in-memory results. A row count higher than this amount will cause the VtGateWarnings.ResultsExceeded counter to be incremented. (default 30000)
--warn-payload-size int The warning threshold for query payloads in bytes. A payload greater than this threshold will cause the VtGateWarnings.WarnPayloadSizeExceeded counter to be incremented.
--warn-sharded-only If any features that are only available in unsharded mode are used, query execution warnings will be added to the session
Loading
Loading