Fix flakey vstream metrics test

[twthorn]

Description

I noticed this test was causing code coverage failures in some other PRs (eg 1, 2) so put out a PR for the fix

We can see it passes

2025-05-21T23:07:45.8461163Z ok  	vitess.io/vitess/go/vt/vtgate	60.112s	coverage: 10.0% of statements in vitess.io/vitess/go/...

Reviewed failing tests, none are from vstream_manager_test.go which is the only file changed in this PR. They seem to be unrelated & flakey and are failing on other PRs.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[deepthi]

Thanks!

[deepthi]

Ugh a bunch of tests are still failing. You will need to look into them.

[twthorn]

@deepthi It seems like failures are from other flakey tests in the repo. I only changed this vstream_manager test file. If this test were the issue, I would expect to see vstream_manager_test failing, but none of them show this test failing. For example End to End Test (Race):

2025-05-21T23:02:57.2997568Z FAIL	vitess.io/vitess/go/vt/vttablet/endtoend	80.451s

I also noticed that lots of other PRs have a similar set of tests failing. I cannot trigger a rerun of the failing ones, but if they are flakey maybe they just need to be reran? If I can be granted rerun permissions I would try that.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (c3daef3) to head (12d9031).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18287      +/-   ##
==========================================
- Coverage   67.46%   67.46%   -0.01%     
==========================================
  Files        1602     1602              
  Lines      262245   262245              
==========================================
- Hits       176930   176917      -13     
- Misses      85315    85328      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rohit-nayak-ps]

I also noticed that lots of other PRs have a similar set of tests failing. I cannot trigger a rerun of the failing ones, but if they are flakey maybe they just need to be reran? If I can be granted rerun permissions I would try that.

We have an auto-retry bot for flaky tests that had stopped running. I fixed that and now it looks like those tests are passing now. I will merge this once all tests pass.

[twthorn]

@rohit-nayak-ps thanks for adding the reruns back

I only see vtgate_queries_timeout failing. I see this as the one failing test on other unrelated PRs eg #18291

We only changed vstream_manager test file, this would not affect vtgate query path.

Can we merge it anyways, or can we rerun this test till it passes? Seems quite flakey