vttablet: allow --init_tablet_type DRAINED#18179
vttablet: allow --init_tablet_type DRAINED#18179timvaillancourt wants to merge 1 commit intovitessio:mainfrom
vttablet: allow --init_tablet_type DRAINED#18179Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18179 +/- ##
=======================================
Coverage 67.53% 67.54%
=======================================
Files 1601 1601
Lines 261484 261484
=======================================
+ Hits 176592 176617 +25
+ Misses 84892 84867 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arthurschreiber
left a comment
There was a problem hiding this comment.
Neat! We would definitely be able to make use of this too.
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
@timvaillancourt There were some discussion on this in Slack. https://vitess.slack.com/archives/C02GSRZ8XAN/p1744809259637539 From there looks like we do not want the vttablet to start with |
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
Description
This PR allows
vttabletto start-up asDRAINED, via the existing--init_tablet_typeflagToday only
REPLICA,RDONLYandSPAREare accepted, however none of these types allow a tablet to be started that is ignored by both VTOrc and VTGate. See issue for more context: #18178Related Issue(s)
Resolves #18178
Checklist
Deployment Notes