Add TMC RPCs for updating sequences for switchwrites#18172
Merged
rohit-nayak-ps merged 8 commits intovitessio:mainfrom Apr 24, 2025
Merged
Add TMC RPCs for updating sequences for switchwrites#18172rohit-nayak-ps merged 8 commits intovitessio:mainfrom
switchwrites#18172rohit-nayak-ps merged 8 commits intovitessio:mainfrom
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
301f2d9 to
b1a5d19
Compare
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18172 +/- ##
==========================================
- Coverage 67.55% 67.50% -0.06%
==========================================
Files 1601 1601
Lines 261424 261576 +152
==========================================
- Hits 176599 176570 -29
- Misses 84825 85006 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
rohit-nayak-ps
approved these changes
Apr 22, 2025
| repeated SequenceMetadata sequences = 1; | ||
| } | ||
|
|
||
| message GetMaxValueForSequencesResponse { |
Member
There was a problem hiding this comment.
Let's add a comment here about what this map's key is.
shlomi-noach
approved these changes
Apr 24, 2025
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 2 TMC RPCs:
GetMaxValueForSequences: Gets the max used sequence value mapped with the provided backing sequence tables.UpdateSequenceTables: Updates all the sequence tables listed in the request, with the max value provided in the sequence metadata.Instead of separate RPC calls for each table per shard, these 2 RPCs allow it to reduce to just 1 RPC call (all tables at once) per shard for fetching and updating max sequence value each.
Related Issue(s)
Checklist
Deployment Notes