Add TransactionsProcessed metric to track transactions at VTGate#18171
Merged
harshit-gangal merged 3 commits intovitessio:mainfrom May 22, 2025
Merged
Add TransactionsProcessed metric to track transactions at VTGate#18171harshit-gangal merged 3 commits intovitessio:mainfrom
harshit-gangal merged 3 commits intovitessio:mainfrom
Conversation
…d transaction type as dimension Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18171 +/- ##
=======================================
Coverage 67.53% 67.54%
=======================================
Files 1601 1601
Lines 261484 261509 +25
=======================================
+ Hits 176592 176628 +36
+ Misses 84892 84881 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
frouioui
reviewed
May 21, 2025
Comment on lines
+79
to
+84
| case TXReadOnly: | ||
| return "ReadOnly" | ||
| case TXReadWrite: | ||
| return "ReadWrite" | ||
| default: | ||
| return "Unknown" |
Member
There was a problem hiding this comment.
These should probably be constants
frouioui
approved these changes
May 21, 2025
GuptaManan100
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new counter metric
TransactionsProcessedto VTGate to track the number of transactions processed, categorized by:Related Issue(s)
Checklist
Deployment Notes