bugfix: INSERT IGNORE not inserting rows#18151
Merged
systay merged 3 commits intovitessio:mainfrom Apr 11, 2025
Merged
Conversation
…ignores the row Signed-off-by: Andres Taylor <andres@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
This was referenced Apr 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18151 +/- ##
==========================================
+ Coverage 67.53% 67.56% +0.02%
==========================================
Files 1601 1601
Lines 261839 261883 +44
==========================================
+ Hits 176839 176938 +99
+ Misses 85000 84945 -55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
approved these changes
Apr 11, 2025
| utils.AssertMatches(t, mcmp.VtConn, `select * from uks.j_utbl order by id`, | ||
| `[[INT64(1) JSON("{}")] [INT64(2) JSON("{\"a\": 1, \"b\": 2}")] [INT64(3) JSON("{\"k\": \"a\"}")] [INT64(4) JSON("{\"date\": 1629849600, \"keywordSourceId\": 930701976723823, \"keywordSourceVersionId\": 210825230433}")]]`) | ||
| } | ||
|
|
harshit-gangal
approved these changes
Apr 11, 2025
GuptaManan100
approved these changes
Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vtgate was failing to insert to the base table when one of the vindexes reported it had ignored a row.
Related Issue(s)
Fixes #17979
Checklist