Skip to content

bugfix: INSERT IGNORE not inserting rows#18151

Merged
systay merged 3 commits intovitessio:mainfrom
planetscale:fix-17979
Apr 11, 2025
Merged

bugfix: INSERT IGNORE not inserting rows#18151
systay merged 3 commits intovitessio:mainfrom
planetscale:fix-17979

Conversation

@systay
Copy link
Collaborator

@systay systay commented Apr 10, 2025

Description

vtgate was failing to insert to the base table when one of the vindexes reported it had ignored a row.

Related Issue(s)

Fixes #17979

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

…ignores the row

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 10, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 10, 2025
@systay systay added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 10, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Apr 10, 2025
@systay systay changed the title fix: make sure to insert rows into the base table even if the vindex ignores the row bugfix: INSERT IGNORE not inserting rows Apr 10, 2025
@systay systay added the Backport to: release-22.0 Needs to be backport to release-22.0 label Apr 10, 2025
@systay systay marked this pull request as ready for review April 10, 2025 12:12
This was referenced Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (0bf2eb1) to head (ea1c27b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18151      +/-   ##
==========================================
+ Coverage   67.53%   67.56%   +0.02%     
==========================================
  Files        1601     1601              
  Lines      261839   261883      +44     
==========================================
+ Hits       176839   176938      +99     
+ Misses      85000    84945      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Andres Taylor <andres@planetscale.com>
utils.AssertMatches(t, mcmp.VtConn, `select * from uks.j_utbl order by id`,
`[[INT64(1) JSON("{}")] [INT64(2) JSON("{\"a\": 1, \"b\": 2}")] [INT64(3) JSON("{\"k\": \"a\"}")] [INT64(4) JSON("{\"date\": 1629849600, \"keywordSourceId\": 930701976723823, \"keywordSourceVersionId\": 210825230433}")]]`)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test description

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay mentioned this pull request Apr 11, 2025
5 tasks
@systay systay merged commit d2a4a4b into vitessio:main Apr 11, 2025
101 checks passed
@systay systay deleted the fix-17979 branch April 11, 2025 08:41
vitess-bot pushed a commit that referenced this pull request Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot pushed a commit that referenced this pull request Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot pushed a commit that referenced this pull request Apr 11, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay mentioned this pull request Apr 11, 2025
5 tasks
frouioui pushed a commit that referenced this pull request Apr 11, 2025
)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
harshit-gangal pushed a commit that referenced this pull request Jul 30, 2025
)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Incorrect Row Insertion Due to Null Handling in Vindex Columns

4 participants