Skip to content

[release-19.0] DML test fix for duplicate column value#18131

Closed
harshit-gangal wants to merge 1 commit intovitessio:release-19.0from
planetscale:backport-17980-release-19.0
Closed

[release-19.0] DML test fix for duplicate column value#18131
harshit-gangal wants to merge 1 commit intovitessio:release-19.0from
planetscale:backport-17980-release-19.0

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

Description

This is a backport of #17980

…vitessio#17980) (vitessio#17987)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Apr 8, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 8, 2025
@harshit-gangal harshit-gangal changed the base branch from main to release-19.0 April 8, 2025 06:35
@github-actions github-actions bot added this to the v23.0.0 milestone Apr 8, 2025
@harshit-gangal harshit-gangal removed the request for review from rohit-nayak-ps April 8, 2025 06:35
@harshit-gangal harshit-gangal reopened this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant