Skip to content

[release-22.0] VStream API: Reset stopPos in catchup (#18119)#18123

Merged
frouioui merged 1 commit intorelease-22.0from
backport-18119-to-release-22.0
Apr 7, 2025
Merged

[release-22.0] VStream API: Reset stopPos in catchup (#18119)#18123
frouioui merged 1 commit intorelease-22.0from
backport-18119-to-release-22.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Apr 6, 2025

Description

This is a backport of #18119

Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Apr 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v22.0.0 milestone Apr 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-22.0@db2c533). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...o/vt/vttablet/tabletserver/vstreamer/uvstreamer.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-22.0   #18123   +/-   ##
===============================================
  Coverage                ?   67.55%           
===============================================
  Files                   ?     1600           
  Lines                   ?   261365           
  Branches                ?        0           
===============================================
  Hits                    ?   176568           
  Misses                  ?    84797           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Apr 7, 2025
@frouioui frouioui merged commit 8868a33 into release-22.0 Apr 7, 2025
205 of 206 checks passed
@frouioui frouioui deleted the backport-18119-to-release-22.0 branch April 7, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants