Online DDL: support alter vitess_migration ... postpone complete syntax#18118
Merged
shlomi-noach merged 10 commits intovitessio:mainfrom Apr 29, 2025
Merged
Online DDL: support alter vitess_migration ... postpone complete syntax#18118shlomi-noach merged 10 commits intovitessio:mainfrom
alter vitess_migration ... postpone complete syntax#18118shlomi-noach merged 10 commits intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18118 +/- ##
==========================================
- Coverage 67.53% 67.45% -0.09%
==========================================
Files 1601 1601
Lines 261484 262150 +666
==========================================
+ Hits 176592 176828 +236
- Misses 84892 85322 +430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohit-nayak-ps
approved these changes
Apr 6, 2025
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
alter vitess_migration ... postpone syntaxalter vitess_migration ... postpone complete syntax
Contributor
Author
|
Changed syntax from |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
deepthi
approved these changes
Apr 29, 2025
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
Docs PR: vitessio/website#1991 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new queries:
alter vitess_migration '<uuid>' postpone completealter vitess_migration postpone complete allWith these two queries, it is possible to set
postpone_completionon already running migrations that are not postponed. The use case in particular is for when a migration seems to run into an endless cut-over sequence and is unable to complete. It may be desired to withhold completion until further notice.These commands are the opposite of
alter vitess_migration ... complete [all]commands, and can alternate back and forth multiple times in the lifetime of the migration.Related Issue(s)
OnlineDDL complete#18107alter vitess_migration ... postpone completewebsite#1991Checklist
Deployment Notes