Skip to content

[release-20.0] fix: App and Dba Pool metrics (#18048)#18083

Merged
harshit-gangal merged 2 commits intorelease-20.0from
backport-18048-to-release-20.0
Apr 8, 2025
Merged

[release-20.0] fix: App and Dba Pool metrics (#18048)#18083
harshit-gangal merged 2 commits intorelease-20.0from
backport-18048-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Apr 1, 2025

Description

This is a backport of #18048

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner April 1, 2025 07:00
@vitess-bot vitess-bot bot added the Backport This is a backport label Apr 1, 2025
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner April 1, 2025 07:00
@vitess-bot vitess-bot bot added the Component: Observability Pull requests that touch tracing/metrics/monitoring label Apr 1, 2025
@vitess-bot vitess-bot bot requested a review from rohit-nayak-ps as a code owner April 1, 2025 07:00
@vitess-bot vitess-bot bot requested a review from systay as a code owner April 1, 2025 07:00
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Apr 1, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested review from GuptaManan100, deepthi and vmg April 1, 2025 07:00
@github-actions github-actions bot added this to the v20.0.7 milestone Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (e9e2704) to head (5e441aa).
Report is 8 commits behind head on release-20.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #18083      +/-   ##
================================================
+ Coverage         66.42%   66.53%   +0.10%     
================================================
  Files              1543     1543              
  Lines            244697   245772    +1075     
================================================
+ Hits             162549   163526     +977     
- Misses            82148    82246      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frouioui frouioui mentioned this pull request Apr 7, 2025
32 tasks
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 78ad09a into release-20.0 Apr 8, 2025
185 checks passed
@harshit-gangal harshit-gangal deleted the backport-18048-to-release-20.0 branch April 8, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTTablet Type: Regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants