Add a new implementation for handling multiple queries without needing to split them#18059
Merged
GuptaManan100 merged 25 commits intovitessio:mainfrom Apr 9, 2025
Merged
Add a new implementation for handling multiple queries without needing to split them#18059GuptaManan100 merged 25 commits intovitessio:mainfrom
GuptaManan100 merged 25 commits intovitessio:mainfrom
Conversation
…d execute multi Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18059 +/- ##
==========================================
- Coverage 67.56% 67.48% -0.08%
==========================================
Files 1601 1601
Lines 261416 261861 +445
==========================================
+ Hits 176618 176712 +94
- Misses 84798 85149 +351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…ing a callback Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Member
harshit-gangal
left a comment
There was a problem hiding this comment.
I think we should add e2e test for grpc client and server implementation. It can go in here: go/test/endtoend/vtgate/grpc_api
harshit-gangal
approved these changes
Apr 8, 2025
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
harshit-gangal
approved these changes
Apr 8, 2025
vitess-bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
…g to split them (#18059) Signed-off-by: Manan Gupta <manan@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability described in #18094. With the changes in this PR -
ExecuteMultiandStreamExecuteMultiThis allows users to be able to import the connection code, and send the queries down to vtgate without splitting them up on their side like they used to before. Since this is a new feature that introduces RPCs it is not immediately backward compatible. So, we've put this feature behind a flag and users need to explicitly opt into it, if they want this behaviour.
Related Issue(s)
Checklist
Deployment Notes