Refactor grpc flags for standardized naming #18009
Merged
rohit-nayak-ps merged 14 commits intovitessio:flags-refactorfrom Apr 5, 2025
Merged
Refactor grpc flags for standardized naming #18009rohit-nayak-ps merged 14 commits intovitessio:flags-refactorfrom
rohit-nayak-ps merged 14 commits intovitessio:flags-refactorfrom
Conversation
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## flags-refactor #18009 +/- ##
==================================================
+ Coverage 67.54% 67.57% +0.02%
==================================================
Files 1598 1598
Lines 259808 259817 +9
==================================================
+ Hits 175497 175566 +69
+ Misses 84311 84251 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohit-nayak-ps
approved these changes
Apr 5, 2025
| # mise files | ||
| .mise.toml | ||
| /errors/ | ||
| go/flags/endtoend/count_flags.sh |
Member
There was a problem hiding this comment.
Let's add this to git for now. We can remove once the refactor is done. You can do this in a future PR, don't want to hold this one up for it.
7f16f70
into
vitessio:flags-refactor
107 of 109 checks passed
mounicasruthi
added a commit
to mounicasruthi/vitess
that referenced
this pull request
May 20, 2025
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
mounicasruthi
added a commit
to mounicasruthi/vitess
that referenced
this pull request
May 20, 2025
Signed-off-by: mounicasruthi <mounicasruthi30@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of an ongoing change to support the transition from underscores (
_) to dashes (-) in flag naming conventions.Flags Updated in This PR:
--grpc-auth-mode
--grpc-auth-mtls-allowed-substrings
--grpc-auth-static-client-creds
--grpc-auth-static-password-file
--grpc-bind-address
--grpc-ca
--grpc-cert
--grpc-compression
--grpc-crl
--grpc-dial-concurrency-limit
--grpc-enable-optional-tls
--grpc-enable-tracing
--grpc-initial-conn-window-size
--grpc-initial-window-size
--grpc-keepalive-time
--grpc-keepalive-timeout
--grpc-key
--grpc-max-connection-age
--grpc-max-connection-age-grace
--grpc-max-message-size
--grpc-port
--grpc-prometheus
--grpc-server-ca
--grpc-server-initial-conn-window-size
--grpc-server-initial-window-size
--grpc-server-keepalive-enforcement-policy-min-time
--grpc-server-keepalive-enforcement-policy-permit-without-stream
--grpc-server-keepalive-time
--grpc-server-keepalive-timeout
--grpc-use-effective-callerid
--grpc-use-effective-groups
--grpc-use-static-authentication-callerid
Flag Count Before vs After:
_-# of migrated flags: 234
Related Issue(s)
#17880
Checklist