vtorc: add stats to shard locks and instance discovery#17977
Merged
deepthi merged 1 commit intovitessio:mainfrom Apr 1, 2025
Merged
vtorc: add stats to shard locks and instance discovery#17977deepthi merged 1 commit intovitessio:mainfrom
vtorc: add stats to shard locks and instance discovery#17977deepthi merged 1 commit intovitessio:mainfrom
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vtorc: add stats to shard locksvtorc: add stats to shard locks and instance discovery
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17977 +/- ##
==========================================
- Coverage 67.56% 67.55% -0.01%
==========================================
Files 1597 1597
Lines 259880 259897 +17
==========================================
+ Hits 175575 175584 +9
- Misses 84305 84313 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
9db66d3 to
0071555
Compare
5 tasks
deepthi
approved these changes
Apr 1, 2025
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Apr 17, 2025
…629) * `vtorc`: add stats to shard locks and instance discovery Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * missing import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * force CI to run again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
5 tasks
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
May 1, 2025
* `vtorc`: add stats to shard locks and instance discovery (vitessio#17977) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Check `consultopo` loaded >0 credentials Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test, again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds stats to shard locks and
DiscoverInstancein VTOrcAlso
logic.LockShard(...)was moved togo/vt/vtorc/logic/topology_recovery.gobecause it's not related to tablet discovery and is only called intopology_recovery.goRelated Issue(s)
#17330
Checklist
Deployment Notes