Skip to content

vtorc: add stats to shard locks and instance discovery#17977

Merged
deepthi merged 1 commit intovitessio:mainfrom
timvaillancourt:vtorc-lock-stats
Apr 1, 2025
Merged

vtorc: add stats to shard locks and instance discovery#17977
deepthi merged 1 commit intovitessio:mainfrom
timvaillancourt:vtorc-lock-stats

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Mar 17, 2025

Description

This PR adds stats to shard locks and DiscoverInstance in VTOrc

Also logic.LockShard(...) was moved to go/vt/vtorc/logic/topology_recovery.go because it's not related to tablet discovery and is only called in topology_recovery.go

Related Issue(s)

#17330

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTOrc Vitess Orchestrator integration labels Mar 17, 2025
@timvaillancourt timvaillancourt self-assigned this Mar 17, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 17, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 17, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 17, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 17, 2025
@timvaillancourt timvaillancourt changed the title vtorc: add stats to shard locks vtorc: add stats to shard locks and instance discovery Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (dd5d4c8) to head (0071555).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/logic/topology_recovery.go 5.71% 33 Missing ⚠️
go/vt/vtorc/logic/vtorc.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17977      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files        1597     1597              
  Lines      259880   259897      +17     
==========================================
+ Hits       175575   175584       +9     
- Misses      84305    84313       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 6658d1c into vitessio:main Apr 1, 2025
103 checks passed
@timvaillancourt timvaillancourt deleted the vtorc-lock-stats branch April 1, 2025 10:56
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Apr 17, 2025
…629)

* `vtorc`: add stats to shard locks and instance discovery

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* missing import

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* force CI to run again

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* empty commit

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Apr 24, 2025
)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 1, 2025
* `vtorc`: add stats to shard locks and instance discovery (vitessio#17977)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Check `consultopo` loaded >0 credentials

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix test, again

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTOrc Vitess Orchestrator integration Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants