Fix sync import error in keyspace_shard_discovery.go#17972
Merged
rohit-nayak-ps merged 1 commit intovitessio:mainfrom Mar 17, 2025
Merged
Fix sync import error in keyspace_shard_discovery.go#17972rohit-nayak-ps merged 1 commit intovitessio:mainfrom
sync import error in keyspace_shard_discovery.go#17972rohit-nayak-ps merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
harshit-gangal
approved these changes
Mar 17, 2025
rohit-nayak-ps
approved these changes
Mar 17, 2025
frouioui
approved these changes
Mar 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17972 +/- ##
==========================================
- Coverage 67.55% 67.55% -0.01%
==========================================
Files 1597 1597
Lines 259842 259841 -1
==========================================
- Hits 175549 175529 -20
- Misses 84293 84312 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@beingnoble03 looks like my PR #17857 introduced this, but it also seemed to pass CI. I wonder how it managed to pass CI and become mergeable 🤔. Anyways thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the recent import error in
keyspace_shard_discovery.go.Related Issue(s)
Checklist
Deployment Notes