Schema Engine Reload: check for file and allocated size columns to be available #17967
Merged
rohit-nayak-ps merged 5 commits intovitessio:mainfrom Mar 15, 2025
Conversation
…for 5.7 flavor, where the Base query is used for WithSizes Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17967 +/- ##
==========================================
- Coverage 67.55% 67.55% -0.01%
==========================================
Files 1597 1597
Lines 259842 259843 +1
==========================================
- Hits 175549 175527 -22
- Misses 84293 84316 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
dbussink
approved these changes
Mar 14, 2025
frouioui
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#17855 introduced a bug where a codepath which expected the additional columns from a "WithSizes" query was not handled, resulting in VTTablet panics when a 5.7 flavor was used.
This was only released to v22, so no need to backport.
Related Issue(s)
fixes #17856
Checklist
Deployment Notes