Skip to content

[release-20.0] Bump golang.org/x/net from 0.34.0 to 0.36.0 (#17958)#17959

Closed
vitess-bot[bot] wants to merge 1 commit intorelease-20.0from
backport-17958-to-release-20.0
Closed

[release-20.0] Bump golang.org/x/net from 0.34.0 to 0.36.0 (#17958)#17959
vitess-bot[bot] wants to merge 1 commit intorelease-20.0from
backport-17958-to-release-20.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Mar 13, 2025

Description

This is a backport of #17958

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI dependencies Pull requests that update a dependency file go Merge Conflict Skip CI Skip CI actions from running Type: Dependencies Dependency updates labels Mar 13, 2025
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Mar 13, 2025

Hello @dependabot[bot], there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17959 -R vitessio/vitess
git reset --hard origin/release-20.0
git cherry-pick -m 1 bbba2127cec9aa7e3a1808b1fdee6b16789e1429

@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Mar 13, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.7 milestone Mar 13, 2025
go.uber.org/mock v0.5.0
golang.org/x/crypto v0.35.0 // indirect
golang.org/x/mod v0.23.0 // indirect
golang.org/x/net v0.36.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this ends up needing Go 1.23.0 now, which is a problem here. See golang/net@5095d0c

@dbussink
Copy link
Copy Markdown
Member

Going to close this as I don't think this issue warrants needing to upgrade Go for Vitess 20.

@dbussink dbussink closed this Mar 13, 2025
@dbussink dbussink deleted the backport-17958-to-release-20.0 branch March 13, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI dependencies Pull requests that update a dependency file go Merge Conflict Skip CI Skip CI actions from running Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant