Unsharded support for CREATE PROCEDURE and DROP PROCEDURE statement #17946
Merged
GuptaManan100 merged 33 commits intovitessio:mainfrom Apr 1, 2025
Merged
Unsharded support for CREATE PROCEDURE and DROP PROCEDURE statement #17946GuptaManan100 merged 33 commits intovitessio:mainfrom
CREATE PROCEDURE and DROP PROCEDURE statement #17946GuptaManan100 merged 33 commits intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…nd use that to implement ParseMultiple and remove parse next Signed-off-by: Manan Gupta <manan@planetscale.com>
…est expectations Signed-off-by: Manan Gupta <manan@planetscale.com>
…atement is incomplete Signed-off-by: Manan Gupta <manan@planetscale.com>
a9110ce to
324fa32
Compare
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…ng for create procedure statements Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17946 +/- ##
==========================================
- Coverage 67.58% 67.54% -0.04%
==========================================
Files 1598 1600 +2
Lines 260323 261288 +965
==========================================
+ Hits 175930 176482 +552
- Misses 84393 84806 +413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
systay
reviewed
Mar 28, 2025
systay
reviewed
Mar 28, 2025
systay
reviewed
Mar 28, 2025
…ruct Signed-off-by: Manan Gupta <manan@planetscale.com>
systay
approved these changes
Mar 28, 2025
Member
harshit-gangal
left a comment
There was a problem hiding this comment.
do we support drop procedure? If not, I believe we need to add that support as well
harshit-gangal
requested changes
Mar 31, 2025
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
CREATE PROCEDURE statement CREATE PROCEDURE and DROP PROCEDURE statement
Signed-off-by: Manan Gupta <manan@planetscale.com>
harshit-gangal
approved these changes
Apr 1, 2025
Signed-off-by: Manan Gupta <manan@planetscale.com>
|
@GuptaManan100 Are there any plans to add |
Contributor
Author
|
No not at the moment |
This was referenced May 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to vtgate to run basic
CREATE PROCEDUREandDROP PROCEDUREstatements. The following changes needed to be made for this support -CREATE PROCEDUREandDROP PROCEDUREstatements.SplitStatementsToPiecesto split create procedure statements properly. This requiring us to also parse the statement since create procedure statements can have multiple;tokens in them, and just splitting on;is no longer enough.This PR also changes the e2e test for procedures to create them using 2 methods, one through the
ApplySchemacall, and the other through the vtgate connection.Related Issue(s)
Checklist
Deployment Notes