Query buffering, terminating blocking transactions for INSTANT DDL and other "special plans"#17945
Merged
shlomi-noach merged 1 commit intovitessio:mainfrom Apr 28, 2025
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17945 +/- ##
==========================================
- Coverage 67.56% 67.54% -0.03%
==========================================
Files 1597 1597
Lines 259763 259849 +86
==========================================
+ Hits 175506 175507 +1
- Misses 84257 84342 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepthi
approved these changes
Apr 28, 2025
rohit-nayak-ps
approved these changes
Apr 28, 2025
Contributor
Author
|
Documentation PR: vitessio/website#1990 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17944
This PR introduces query buffering and forced query/transaction termination for special plan operations, which at this time include
INSTANTDDL and range partition rotation.--prefer-instant-ddlstrategy flag is supplied, or is found to be a range partition rotation change)--force-cut-over-durationflag is nonzero, and irrespective of its value, we also issue a one time termination for queries and transactions holding locks or metadata locks on the migrated table, just before issuing theALTER TABLEstatement.In the future we may also consider terminating queries/transactions while a migration is being stalled.
Related Issue(s)
#17944
Documentation: vitessio/website#1990
Checklist
Deployment Notes