Fix semi-sync monitor bug of expecting incorrect number of fields#17939
Merged
shlomi-noach merged 1 commit intovitessio:mainfrom Mar 10, 2025
Merged
Fix semi-sync monitor bug of expecting incorrect number of fields#17939shlomi-noach merged 1 commit intovitessio:mainfrom
shlomi-noach merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
shlomi-noach
approved these changes
Mar 10, 2025
rohit-nayak-ps
approved these changes
Mar 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17939 +/- ##
==========================================
- Coverage 67.56% 67.54% -0.02%
==========================================
Files 1597 1597
Lines 259775 259782 +7
==========================================
- Hits 175509 175471 -38
- Misses 84266 84311 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug described in #17938. The problem of expecting incorrect number of fields has been fixed. There is an e2e test that would have caught this bug when the semi-sync monitor was introduced in #17763, but the test doesn't run on CI and I didn't run it locally after addressing the review comments as part of which I changed the query that the semi-sync monitor was running.
This time I have ensured that the e2e test is now working as expected after the fix.
Related Issue(s)
Checklist
Deployment Notes