Skip to content

[release-21.0] evalengine: normalize types during compilation (#17887) #17896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
systay merged 1 commit into from
Mar 4, 2025
Merged

[release-21.0] evalengine: normalize types during compilation (#17887) #17896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions go/vt/vtgate/evalengine/expr_bvar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,13 @@ func (bvar *BindVariable) compile(c *compiler) (ctype, error) {

switch tt := typ.Type; {
case sqltypes.IsSigned(tt):
typ.Type = sqltypes.Int64
c.asm.PushBVar_i(bvar.Key)
case sqltypes.IsUnsigned(tt):
typ.Type = sqltypes.Uint64
c.asm.PushBVar_u(bvar.Key)
case sqltypes.IsFloat(tt):
typ.Type = sqltypes.Float64
c.asm.PushBVar_f(bvar.Key)
case sqltypes.IsDecimal(tt):
c.asm.PushBVar_d(bvar.Key)
Expand All @@ -146,9 +149,11 @@ func (bvar *BindVariable) compile(c *compiler) (ctype, error) {
typ.Type = sqltypes.VarBinary
typ.Flag |= flagBit
} else {
typ.Type = sqltypes.VarChar
c.asm.PushBVar_text(bvar.Key, typ.Col)
}
case sqltypes.IsBinary(tt):
typ.Type = sqltypes.VarBinary
c.asm.PushBVar_bin(bvar.Key)
case sqltypes.IsNull(tt):
c.asm.PushNull()
Expand Down
16 changes: 16 additions & 0 deletions go/vt/vtgate/evalengine/translate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,3 +452,19 @@ func TestCardinalityWithBindVariables(t *testing.T) {
})
}
}

func TestBindVarType(t *testing.T) {
lhs := sqlparser.NewTypedArgument("lhs", sqltypes.Int32)
rhs := sqlparser.NewTypedArgument("rhs", sqltypes.Int64)
venv := vtenv.NewTestEnv()
cmp := &sqlparser.ComparisonExpr{
Operator: sqlparser.EqualOp,
Left: lhs,
Right: rhs,
}
_, err := Translate(cmp, &Config{
Collation: venv.CollationEnv().DefaultConnectionCharset(),
Environment: venv,
})
require.NoError(t, err)
}
Loading